Wael Nasreddine
cb016c4307
Address Gemini's comment
2025-12-25 16:26:58 -08:00
Wael Nasreddine
7c7797d35a
fix(share/prev_next): Prevent crashing if candide page is null
...
When a note is not visible, attempting to export it ends up crashing the
server with this error:
```
TypeError: ejs:193
191|
192| <% if (hasTree) { %>
>> 193| <%- include("prev_next", { note: note, subRoot: subRoot }) %>
194| <% } %>
195| </footer>
196| </div>
ejs:1
>> 1| <%
2| // TODO: code cleanup + putting this behind a toggle/attribute
3| const previousNote = (() => {
4| // If we are at the subRoot, there is no previous
Cannot read properties of undefined (reading 'hasVisibleChildren')
at eval (eval at compile (/usr/src/app/main.cjs:553:203), <anonymous>:27:26)
at eval (eval at compile (/usr/src/app/main.cjs:553:203), <anonymous>:34:7)
at d (/usr/src/app/main.cjs:557:265)
at g (/usr/src/app/main.cjs:557:251)
at eval (eval at compile (/usr/src/app/main.cjs:553:203), <anonymous>:293:17)
at d (/usr/src/app/main.cjs:557:265)
at as.render (/usr/src/app/main.cjs:532:458)
at Omr (/usr/src/app/main.cjs:581:109552)
at Rmr (/usr/src/app/main.cjs:581:107637)
at $W.prepareContent (/usr/src/app/main.cjs:653:28) {
path: ''
```
fixes #8002
fixes #8162
2025-12-25 16:11:01 -08:00
Elian Doran
ae184ab894
feat(share): display note icon in reference links
2025-11-19 09:07:33 +02:00
Elian Doran
416c05ed3b
fix(share): footer navigation doesn't respect #shareHiddenFromTree ( closes #7781 )
2025-11-19 08:43:57 +02:00
Elian Doran
6322ca11c9
feat(share): improve webview layout
2025-11-01 21:28:31 +02:00
Elian Doran
945f29c759
feat(share): render webviews using iframe
2025-10-31 10:12:15 +02:00
Elian Doran
78f067965f
fix(share): TOC indicator no longer working due to layout changes
2025-10-30 08:49:48 +02:00
Elian Doran
496091677b
style(share): overflow on wrong element
2025-10-29 20:14:32 +02:00
Elian Doran
618b67f551
fix(share): redesign layout to avoid jumping on tablets
2025-10-29 20:02:02 +02:00
Elian Doran
ce4f46c226
chore(share): fix relative imports
Checks / main (push) Has been cancelled
2025-10-29 19:13:11 +02:00
Elian Doran
44cfbcf7f4
refactor(share): move icon loading in CSS rather than in JS
2025-10-29 19:11:43 +02:00
Elian Doran
a317331551
fix(share): theme toggle flashing while switching between notes
2025-10-29 19:05:23 +02:00
Elian Doran
eeec3e440d
fix(share): flash while theme is loading
2025-10-29 19:00:09 +02:00
Elian Doran
b06aa29ea3
chore(share): remove leftover color management logic
2025-10-29 18:46:55 +02:00
Elian Doran
9c3f9a524e
fix(share): flash of dark color on light theme
2025-10-29 18:46:24 +02:00
Elian Doran
1c832182d6
refactor(share): reduce duplication in theme management
2025-10-29 18:40:31 +02:00
Elian Doran
b58e1f146c
fix(share): light theme not properly restored
2025-10-29 18:35:27 +02:00
Elian Doran
f1f8f34ef8
fix(export/share): load search index once per page
2025-10-29 15:33:38 +02:00
Elian Doran
a0b19ce526
fix(export/share): search not working on root
2025-10-29 15:26:48 +02:00
Elian Doran
4cc9ba824d
chore(export/share): tweak search results
2025-10-29 15:24:25 +02:00
Elian Doran
08e66c18e7
fix(export/share): navigation in search not working
2025-10-29 14:57:53 +02:00
Elian Doran
cf8089b07f
feat(export/share): functional full-text search
2025-10-29 13:58:37 +02:00
Elian Doran
88d90fdedd
fix(export/share): favicon working only on top-level
2025-10-28 18:23:11 +02:00
Elian Doran
1e2c8b2ac4
fix(export/share): ckcontent CSS missing
2025-10-28 18:16:37 +02:00
Elian Doran
955b202b8a
chore(export/share): hide last updated
2025-10-28 17:59:12 +02:00
Elian Doran
54200fa0cb
chore(export/share): disable non-functional search
2025-10-28 17:33:36 +02:00
Elian Doran
187e9b57de
fix(share): note tree not visible on mobile
2025-10-28 16:57:04 +02:00
Elian Doran
4c3fcdba4a
fix(share): images appearing stretched
2025-10-28 16:34:38 +02:00
Elian Doran
dd5b3a3c1c
chore(server): address requested changes
2025-10-28 15:44:00 +02:00
Elian Doran
14b8d0a47e
chore(share): bring back syntax highlight
Checks / main (push) Has been cancelled
2025-10-27 22:18:08 +02:00
Elian Doran
1182592fc5
chore(share): fix another typecheck issue
Checks / main (push) Waiting to run
2025-10-26 10:07:42 +02:00
Elian Doran
0c399a676a
chore(share): fix typecheck issue
Checks / main (push) Has been cancelled
2025-10-24 23:28:42 +03:00
Elian Doran
395f33cd5b
chore(share): bring back boxicons
2025-10-24 22:32:42 +03:00
Elian Doran
21b20cf575
chore(share): bring back most of the logic
2025-10-24 21:18:06 +03:00
Elian Doran
e3dd25b591
chore(share): set up math
2025-10-24 21:13:40 +03:00
Elian Doran
6ae67c410c
chore(share): load Mermaid only when necessary
2025-10-24 20:52:47 +03:00
Elian Doran
4ef7667484
chore(share): bring back inline mermaid rendering
2025-10-24 19:09:19 +03:00
Elian Doran
ea53665e64
Merge remote-tracking branch 'origin/main' into feature/export_with_share_theme
2025-10-24 14:43:20 +03:00
Elian Doran
d2b6014b49
fix(share): HTML tags displayed escaped in headings
2025-10-23 14:19:54 +03:00
Elian Doran
94d62f810a
fix(share): heading and navigation not supporting CJK ( closes #6430 )
2025-10-23 14:06:13 +03:00
Kevin Leutzinger
0a25d4db0d
shareHTML to shareHtml
2025-10-01 03:30:16 -04:00
Kevin Leutzinger
d483b6e840
add shareHTML relation
2025-09-30 23:06:20 -04:00
Elian Doran
97b5ea0798
fix(share): text not visible under dark theme in prod
2025-09-23 20:24:54 +03:00
Elian Doran
050aa40e20
fix(dx/share): templates and script not accessible
2025-09-03 12:12:01 +03:00
Elian Doran
7c6af568d8
fix(share): ck text on dark theme not visible ( closes #6427 )
2025-07-22 08:44:45 +03:00
Elian Doran
a2110ca631
fix(export/share): tree not expanding properly
2025-06-24 17:45:06 +03:00
Elian Doran
77e4c3d0ec
refactor(export/share): use different URL rewriting mechanism
2025-06-23 19:28:45 +03:00
Elian Doran
8523050ab2
fix(export/share): note children preview links not working
2025-06-23 19:00:20 +03:00
Elian Doran
01beebf660
feat(export/zip): load script as well
2025-06-14 01:23:02 +03:00
Elian Doran
d3115e834a
feat(export/zip): get logo to work
2025-06-14 01:01:12 +03:00
