From f8e10f36db09905dac504486563b758f2d7d4c7c Mon Sep 17 00:00:00 2001 From: Elian Doran Date: Fri, 27 Jun 2025 21:51:38 +0300 Subject: [PATCH] refactor(note_list): use object for constructor arg --- apps/client/src/services/note_list_renderer.ts | 10 ++-------- apps/client/src/widgets/note_list.ts | 6 +++++- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/apps/client/src/services/note_list_renderer.ts b/apps/client/src/services/note_list_renderer.ts index 9518c3b79..3219d8d92 100644 --- a/apps/client/src/services/note_list_renderer.ts +++ b/apps/client/src/services/note_list_renderer.ts @@ -12,14 +12,8 @@ export default class NoteListRenderer { private viewType: ViewTypeOptions; public viewMode: ViewMode | null; - constructor($parent: JQuery, parentNote: FNote, noteIds: string[], showNotePath: boolean = false) { - this.viewType = this.#getViewType(parentNote); - const args: ViewModeArgs = { - $parent, - parentNote, - noteIds, - showNotePath - }; + constructor(args: ViewModeArgs) { + this.viewType = this.#getViewType(args.parentNote); switch (this.viewType) { case "list": diff --git a/apps/client/src/widgets/note_list.ts b/apps/client/src/widgets/note_list.ts index ba1a028f2..c49e4870c 100644 --- a/apps/client/src/widgets/note_list.ts +++ b/apps/client/src/widgets/note_list.ts @@ -76,7 +76,11 @@ export default class NoteListWidget extends NoteContextAwareWidget { } async renderNoteList(note: FNote) { - const noteListRenderer = new NoteListRenderer(this.$content, note, note.getChildNoteIds()); + const noteListRenderer = new NoteListRenderer({ + $parent: this.$content, + parentNote: note, + noteIds: note.getChildNoteIds() + }); this.$widget.toggleClass("full-height", noteListRenderer.isFullHeight); await noteListRenderer.renderList(); this.viewMode = noteListRenderer.viewMode;