From e5fdd5128a860a72ae3e6f85150669a4de22292f Mon Sep 17 00:00:00 2001 From: zadam Date: Mon, 1 Aug 2022 19:56:09 +0200 Subject: [PATCH] fix password protected notes rejection --- package-lock.json | 1 + src/share/routes.js | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index c46f2add8..2273eb623 100644 --- a/package-lock.json +++ b/package-lock.json @@ -5,6 +5,7 @@ "requires": true, "packages": { "": { + "name": "trilium", "version": "0.53.2", "hasInstallScript": true, "license": "AGPL-3.0-only", diff --git a/src/share/routes.js b/src/share/routes.js index 095498a08..365bc4fba 100644 --- a/src/share/routes.js +++ b/src/share/routes.js @@ -30,7 +30,7 @@ function addNoIndexHeader(note, res) { } } -function reject(res) { +function requestCredentials(res) { res.setHeader('WWW-Authenticate', 'Basic realm="User Visible Realm", charset="UTF-8"') .sendStatus(401); } @@ -55,7 +55,7 @@ function checkNoteAccess(noteId, req, res) { const header = req.header("Authorization"); if (!header?.startsWith("Basic ")) { - reject(res); + requestCredentials(res); return false; } @@ -80,6 +80,8 @@ function register(router) { } if (!checkNoteAccess(note.noteId, req, res)) { + requestCredentials(res); + return; }