wip

src/public/javascripts/widgets/tab_caching_widget.js

@@ -40,13 +40,13 @@ export default class TabCachingWidget extends TabAwareWidget {
 
         if (!widget) {
             widget = this.widgets[this.tabContext.tabId] = this.widgetFactory();
-            this.child(widget);
 
             const $renderedWidget = widget.render();
-            keyboardActionsService.updateDisplayedShortcuts($renderedWidget);
-
             this.$widget.after($renderedWidget);
 
+            keyboardActionsService.updateDisplayedShortcuts($renderedWidget);
+
+            this.child(widget); // add as child only once it is ready (also rendered)
             widget.handleEvent('setTabContext', {tabContext: this.tabContext});
         }
 

src/public/javascripts/widgets/type_widgets/book.js

@@ -293,15 +293,7 @@ export default class BookTypeWidget extends TypeWidget {
         }
     }
 
-    getContent() {}
-
-    focus() {}
-
     cleanup() {
         this.$content.empty();
     }
-
-    scrollToTop() {
-        this.$widget.scrollTop(0);
-    }
 }

src/public/javascripts/widgets/type_widgets/code.js

@@ -132,8 +132,4 @@ export default class CodeTypeWidget extends TypeWidget {
             });
         }
     }
-
-    scrollToTop() {
-        this.$widget.scrollTop(0);
-    }
 }

src/public/javascripts/widgets/type_widgets/empty.js

@@ -38,12 +38,4 @@ export default class EmptyTypeWidget extends TypeWidget {
     doRefresh(note) {
         this.$autoComplete.trigger('focus');
     }
-
-    getContent() {}
-
-    focus() {}
-
-    cleanup() {}
-
-    scrollToTop() {}
 }

src/public/javascripts/widgets/type_widgets/file.js

@@ -144,12 +144,4 @@ export default class FileTypeWidget extends TypeWidget {
     getFileUrl() {
         return utils.getUrlForDownload("api/notes/" + this.noteId + "/download");
     }
-
-    getContent() {}
-
-    focus() {}
-
-    cleanup() {}
-
-    scrollToTop() {}
 }

src/public/javascripts/widgets/type_widgets/image.js

@@ -147,16 +147,6 @@ class ImageTypeWidget extends TypeWidget {
     getFileUrl() {
         return utils.getUrlForDownload(`api/notes/${this.noteId}/download`);
     }
-
-    getContent() {}
-
-    focus() {}
-
-    cleanup() {}
-
-    scrollToTop() {
-        this.$widget.scrollTop(0);
-    }
 }
 
 export default ImageTypeWidget

src/public/javascripts/widgets/type_widgets/protected_session.js

@@ -39,14 +39,4 @@ export default class ProtectedSessionTypeWidget extends TypeWidget {
         
         return this.$widget;
     }
-
-    getContent() {}
-
-    focus() {}
-
-    cleanup() {}
-
-    scrollToTop() {
-        this.$widget.scrollTop(0);
-    }
 }

src/public/javascripts/widgets/type_widgets/relation_map.js

@@ -640,8 +640,4 @@ export default class RelationMapTypeWidget extends TypeWidget {
     getContent() {
         return JSON.stringify(this.mapData);
     }
-
-    focus() {}
-
-    scrollToTop() {}
 }

src/public/javascripts/widgets/type_widgets/render.js

@@ -37,15 +37,7 @@ export default class RenderTypeWidget extends TypeWidget {
         }
     }
 
-    getContent() {}
-
-    focus() {}
-
     cleanup() {
         this.$noteDetailRenderContent.empty();
     }
-
-    scrollToTop() {
-        this.$widget.scrollTop(0);
-    }
 }

src/public/javascripts/widgets/type_widgets/search.js

@@ -48,10 +48,4 @@ export default class SearchTypeWidget extends TypeWidget {
             searchString: this.$searchString.val()
         });
     }
-
-    focus() {}
-
-    cleanup() {}
-
-    scrollToTop() {}
 }

src/public/javascripts/widgets/type_widgets/text.js

@@ -186,10 +186,6 @@ export default class TextTypeWidget extends TypeWidget {
         }
     }
 
-    scrollToTop() {
-        this.$widget.scrollTop(0);
-    }
-
     insertDateTimeToTextCommand() {
         const date = new Date();
         const dateString = utils.formatDateTime(date);

src/public/javascripts/widgets/type_widgets/type_widget.js

@@ -28,4 +28,12 @@ export default class TypeWidget extends TabAwareWidget {
     isActive() {
         return this.$widget.is(":visible");
     }
+
+    getContent() {}
+
+    focus() {}
+
+    scrollToTop() {
+        this.$widget.scrollTop(0);
+    }
 }