diff --git a/src/public/app/desktop.js b/src/public/app/desktop.js index e83f4477e..7b0da9e35 100644 --- a/src/public/app/desktop.js +++ b/src/public/app/desktop.js @@ -8,6 +8,7 @@ import contextMenu from "./menus/context_menu.js"; import DesktopLayout from "./layouts/desktop_layout.js"; import glob from "./services/glob.js"; import zoomService from './components/zoom.js'; +import options from "./services/options.js"; bundleService.getWidgetBundlesByParent().then(widgetBundles => { appContext.setLayout(new DesktopLayout(widgetBundles)); @@ -115,11 +116,27 @@ if (utils.isElectron()) { ? (`${params.selectionText.substr(0, 13)}…`) : params.selectionText; + // Read the search engine from the options and fallback to DuckDuckGo if the option is not set. + const customSearchEngineName = options.get("customSearchEngineName"); + const customSearchEngineUrl = options.get("customSearchEngineUrl"); + let searchEngineName; + let searchEngineUrl; + if (customSearchEngineName && customSearchEngineUrl) { + searchEngineName = customSearchEngineName; + searchEngineUrl = customSearchEngineUrl; + } else { + searchEngineName = "Duckduckgo"; + searchEngineUrl = "https://duckduckgo.com/?q={keyword}"; + } + + // Replace the placeholder with the real search keyword. + let searchUrl = searchEngineUrl.replace("{keyword}", encodeURIComponent(params.selectionText)); + items.push({ enabled: editFlags.canPaste, - title: `Search for "${shortenedSelection}" with DuckDuckGo`, + title: `Search for "${shortenedSelection}" with ${searchEngineName}`, uiIcon: "bx bx-search-alt", - handler: () => electron.shell.openExternal(`https://duckduckgo.com/?q=${encodeURIComponent(params.selectionText)}`) + handler: () => electron.shell.openExternal(searchUrl) }); } diff --git a/src/public/app/widgets/type_widgets/content_widget.js b/src/public/app/widgets/type_widgets/content_widget.js index 627612d6c..694e16dab 100644 --- a/src/public/app/widgets/type_widgets/content_widget.js +++ b/src/public/app/widgets/type_widgets/content_widget.js @@ -18,6 +18,7 @@ import PasswordOptions from "./options/password.js"; import EtapiOptions from "./options/etapi.js"; import BackupOptions from "./options/backup.js"; import SyncOptions from "./options/sync.js"; +import SearchEngineOptions from "./options/other/search_engine.js"; import TrayOptions from "./options/other/tray.js"; import NoteErasureTimeoutOptions from "./options/other/note_erasure_timeout.js"; import NoteRevisionsSnapshotIntervalOptions from "./options/other/note_revisions_snapshot_interval.js"; @@ -76,6 +77,7 @@ const CONTENT_WIDGETS = { _optionsBackup: [ BackupOptions ], _optionsSync: [ SyncOptions ], _optionsOther: [ + SearchEngineOptions, TrayOptions, NoteErasureTimeoutOptions, AttachmentErasureTimeoutOptions, diff --git a/src/public/app/widgets/type_widgets/options/other/search_engine.js b/src/public/app/widgets/type_widgets/options/other/search_engine.js new file mode 100644 index 000000000..081aa0aa8 --- /dev/null +++ b/src/public/app/widgets/type_widgets/options/other/search_engine.js @@ -0,0 +1,78 @@ +import OptionsWidget from "../options_widget.js"; +import utils from "../../../../services/utils.js"; + +const TPL = ` +
`; + +const SEARCH_ENGINES = { + "Bing": "https://www.bing.com/search?q={keyword}", + "Baidu": "https://www.baidu.com/s?wd={keyword}", + "Duckduckgo": "https://duckduckgo.com/?q={keyword}", + "Google": "https://www.google.com/search?q={keyword}", +} + +export default class SearchEngineOptions extends OptionsWidget { + isEnabled() { + return super.isEnabled() && utils.isElectron(); + } + + doRender() { + this.$widget = $(TPL); + + this.$form = this.$widget.find(".sync-setup-form"); + this.$predefinedSearchEngineSelect = this.$widget.find(".predefined-search-engine-select"); + this.$customSearchEngineName = this.$widget.find(".custom-search-engine-name"); + this.$customSearchEngineUrl = this.$widget.find(".custom-search-engine-url"); + + this.$predefinedSearchEngineSelect.on('change', () => { + const predefinedSearchEngine = this.$predefinedSearchEngineSelect.val(); + this.$customSearchEngineName[0].value = predefinedSearchEngine; + this.$customSearchEngineUrl[0].value = SEARCH_ENGINES[predefinedSearchEngine]; + }); + + this.$form.on('submit', () => { + this.updateMultipleOptions({ + 'customSearchEngineName': this.$customSearchEngineName.val(), + 'customSearchEngineUrl': this.$customSearchEngineUrl.val() + }); + }); + } + + async optionsLoaded(options) { + this.$predefinedSearchEngineSelect.val(""); + this.$customSearchEngineName[0].value = options.customSearchEngineName; + this.$customSearchEngineUrl[0].value = options.customSearchEngineUrl; + } +} diff --git a/src/routes/api/options.js b/src/routes/api/options.js index 89a02d726..201d4e266 100644 --- a/src/routes/api/options.js +++ b/src/routes/api/options.js @@ -62,7 +62,10 @@ const ALLOWED_OPTIONS = new Set([ 'minTocHeadings', 'checkForUpdates', 'disableTray', - 'eraseUnusedImageAttachmentsAfterSeconds' + 'eraseUnusedImageAttachmentsAfterSeconds', + 'disableTray', + 'customSearchEngineName', + 'customSearchEngineUrl', ]); function getOptions() { diff --git a/src/services/export/zip.js b/src/services/export/zip.js index 88da1c8b8..a64bbe2c3 100644 --- a/src/services/export/zip.js +++ b/src/services/export/zip.js @@ -318,6 +318,7 @@ async function exportToZip(taskContext, branch, format, res, setHeaders = true) if (noteMeta.format === 'html') { if (!content.substr(0, 100).toLowerCase().includes(" element will make sure external links are openable - https://github.com/zadam/trilium/issues/1289#issuecomment-704066809 content = ` @@ -326,10 +327,11 @@ async function exportToZip(taskContext, branch, format, res, setHeaders = true)