From cbc01e1a8dcf8af0ef6eec5f44559daf8ba76bd0 Mon Sep 17 00:00:00 2001 From: Elian Doran Date: Sun, 18 Feb 2024 20:41:30 +0200 Subject: [PATCH] server-ts: FIXME -> TODO --- src/becca/becca_loader.ts | 2 +- src/becca/entities/abstract_becca_entity.ts | 2 +- src/services/auth.ts | 2 +- src/services/notes.ts | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/becca/becca_loader.ts b/src/becca/becca_loader.ts index f49436292..991fb00e4 100644 --- a/src/becca/becca_loader.ts +++ b/src/becca/becca_loader.ts @@ -183,7 +183,7 @@ function noteUpdated(entityRow: NoteRow) { const note = becca.notes[entityRow.noteId]; if (note) { - // FIXME, this wouldn't have worked in the original implementation since the variable was named __flatTextCache. + // TODO, this wouldn't have worked in the original implementation since the variable was named __flatTextCache. // type / mime could have been changed, and they are present in flatTextCache note.__flatTextCache = null; } diff --git a/src/becca/entities/abstract_becca_entity.ts b/src/becca/entities/abstract_becca_entity.ts index 9476c66d5..bc7d3f06b 100644 --- a/src/becca/entities/abstract_becca_entity.ts +++ b/src/becca/entities/abstract_becca_entity.ts @@ -104,7 +104,7 @@ abstract class AbstractBeccaEntity> { /** * Saves entity - executes SQL, but doesn't commit the transaction on its own */ - // FIXME: opts not used but called a few times, maybe should be used by derived classes or passed to beforeSaving. + // TODO: opts not used but called a few times, maybe should be used by derived classes or passed to beforeSaving. save(opts?: {}): this { const constructorData = (this.constructor as unknown as ConstructorData); const entityName = constructorData.entityName; diff --git a/src/services/auth.ts b/src/services/auth.ts index 0f3ed051c..30f5687f3 100644 --- a/src/services/auth.ts +++ b/src/services/auth.ts @@ -10,7 +10,7 @@ import passwordService = require('./encryption/password'); const noAuthentication = config.General && config.General.noAuthentication === true; -// FIXME: We are using custom types for request & response because couldn't extract those pesky express types. +// TODO: We are using custom types for request & response because couldn't extract those pesky express types. interface Request { method: string; path: string; diff --git a/src/services/notes.ts b/src/services/notes.ts index c03c96a1e..6449081eb 100644 --- a/src/services/notes.ts +++ b/src/services/notes.ts @@ -761,7 +761,7 @@ function updateNoteData(noteId: string, content: string, attachments: BAttachmen const existingAttachmentsByTitle = utils.toMap(note.getAttachments({includeContentLength: false}), 'title'); for (const attachment of attachments) { - // FIXME: The content property was extracted directly instead of `getContent`. To investigate. + // TODO: The content property was extracted directly instead of `getContent`. To investigate. const {attachmentId, role, mime, title, position} = attachment; const content = attachment.getContent(); @@ -834,7 +834,7 @@ function undeleteBranch(branchId: string, deleteId: string, taskContext: TaskCon for (const attributeRow of attributeRows) { // relation might point to a note which hasn't been undeleted yet and would thus throw up - // FIXME: skipValidation is not used. + // TODO: skipValidation is not used. new BAttribute(attributeRow).save({skipValidation: true}); } @@ -1014,7 +1014,7 @@ function duplicateSubtreeInner(origNote: BNote, origBranch: BBranch, newParentNo } // the relation targets may not be created yet, the mapping is pre-generated - // FIXME: This used to be `attr.save({skipValidation: true});`, but skipValidation is in beforeSaving. + // TODO: This used to be `attr.save({skipValidation: true});`, but skipValidation is in beforeSaving. attr.save(); }