From cbad58201e976140d01582485e11382321e1aca2 Mon Sep 17 00:00:00 2001
From: Elian Doran <contact@eliandoran.me>
Date: Sun, 17 Mar 2024 21:40:14 +0200
Subject: [PATCH] server-ts: Solve requested changes

---
 src/becca/similarity.js                          |  2 +-
 .../promoted_attribute_definition_parser.ts      | 16 ++++++++--------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/becca/similarity.js b/src/becca/similarity.js
index b0ed39e13..07f643a7d 100644
--- a/src/becca/similarity.js
+++ b/src/becca/similarity.js
@@ -35,7 +35,7 @@ const IGNORED_ATTR_NAMES = [
 function filterUrlValue(value) {
     return value
         .replace(/https?:\/\//ig, "")
-        .replace(/www\./ig, "")
+        .replace(/www.js\./ig, "")
         .replace(/(\.net|\.com|\.org|\.info|\.edu)/ig, "");
 }
 
diff --git a/src/services/promoted_attribute_definition_parser.ts b/src/services/promoted_attribute_definition_parser.ts
index cd3dc18db..3efe16f4d 100644
--- a/src/services/promoted_attribute_definition_parser.ts
+++ b/src/services/promoted_attribute_definition_parser.ts
@@ -1,15 +1,15 @@
 interface DefinitionObject {
-    isPromoted: boolean;
-    labelType: string;
-    multiplicity: string;
-    numberPrecision: number;
-    promotedAlias: string;
-    inverseRelation: string;
+    isPromoted?: boolean;
+    labelType?: string;
+    multiplicity?: string;
+    numberPrecision?: number;
+    promotedAlias?: string;
+    inverseRelation?: string;
 }
 
 function parse(value: string): DefinitionObject {
     const tokens = value.split(',').map(t => t.trim());
-    const defObj: Partial<DefinitionObject> = {};
+    const defObj: DefinitionObject = {};
 
     for (const token of tokens) {
         if (token === 'promoted') {
@@ -41,7 +41,7 @@ function parse(value: string): DefinitionObject {
         }
     }
 
-    return defObj as DefinitionObject;
+    return defObj;
 }
 
 export = {