gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-06-06 18:08:33 +02:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

client: Hide spellcheck settings on web (closes #345)

Browse Source
This commit is contained in:
Elian Doran 2024-08-16 22:14:19 +03:00
parent 1172908e41
commit ca6b4c3497
No known key found for this signature in database
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
integration-tests/settings.spec.ts
View File

@ -11,3 +11,11 @@ test("Tray settings not displayed on web", async ({ page }) => {
await expect(page.getByRole('heading', { name: 'Note Erasure Timeout' })).toBeVisible(); await expect(page.getByRole('heading', { name: 'Note Erasure Timeout' })).toBeVisible();
await expect(page.getByRole('heading', { name: 'Tray' })).toBeHidden(); await expect(page.getByRole('heading', { name: 'Tray' })).toBeHidden();
}); });
test("Spellcheck settings not displayed on web", async ({ page }) => {
await page.goto('http://localhost:8082/#root/_hidden/_options/_optionsSpellcheck');
await expect(page.getByRole('heading', { name: 'Spell Check' })).toBeVisible();
await expect(page.getByRole('heading', { name: 'Tray' })).toBeHidden();
await expect(page.getByText('These options apply only for desktop builds')).toBeVisible();
await expect(page.getByText('Enable spellcheck')).toBeHidden();
});

15
src/public/app/widgets/type_widgets/options/spellcheck.js
View File

@ -1,11 +1,19 @@
import utils from "../../../services/utils.js"; import utils from "../../../services/utils.js";
import OptionsWidget from "./options_widget.js"; import OptionsWidget from "./options_widget.js";
const TPL = ` const TPL_WEB = `
<div class="options-section"> <div class="options-section">
<h4>Spell Check</h4> <h4>Spell Check</h4>
<p>These options apply only for desktop builds, browsers will use their own native spell check. App restart is required after change.</p> <p>These options apply only for desktop builds, browsers will use their own native spell check.</p>
</div>
`;
const TPL_ELECTRON = `
<div class="options-section">
<h4>Spell Check</h4>
<p>App restart is required after change.</p>
<label> <label>
<input type="checkbox" class="spell-check-enabled"> <input type="checkbox" class="spell-check-enabled">
@ -26,7 +34,8 @@ const TPL = `
export default class SpellcheckOptions extends OptionsWidget { export default class SpellcheckOptions extends OptionsWidget {
doRender() { doRender() {
this.$widget = $(TPL); const template = utils.isElectron() ? TPL_ELECTRON : TPL_WEB;
this.$widget = $(template);
this.$spellCheckEnabled = this.$widget.find(".spell-check-enabled"); this.$spellCheckEnabled = this.$widget.find(".spell-check-enabled");
this.$spellCheckLanguageCode = this.$widget.find(".spell-check-language-code"); this.$spellCheckLanguageCode = this.$widget.find(".spell-check-language-code");