gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2026-01-01 20:24:25 +01:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

fix(pdf_pages): pages not updating between notes

Browse Source
This commit is contained in:
Elian Doran 2025-12-29 22:50:48 +02:00
parent 0d9c8ae4df
commit c1d6b3121a
No known key found for this signature in database
1 changed files with 6 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
apps/client/src/widgets/sidebar/PdfPages.tsx
View File

@ -16,7 +16,7 @@ export default function PdfPages() {
return (
<RightPanelWidget id="pdf-pages" title="Pages" grow>
<PdfPagesList />
<PdfPagesList key={note.noteId} />
</RightPanelWidget>
);
}
@ -42,6 +42,7 @@ function PdfPagesList() {
const requestThumbnail = useCallback((pageNumber: number) => {
// Only request if we haven't already requested it and don't have it
if (!requestedThumbnails.current.has(pageNumber) && !thumbnails.has(pageNumber) && pagesData) {
console.log("[PdfPages] Requesting thumbnail for page:", pageNumber);
requestedThumbnails.current.add(pageNumber);
pagesData.requestThumbnail(pageNumber);
}
@ -79,43 +80,18 @@ function PdfPageItem({
pageNumber: number;
isActive: boolean;
thumbnail?: string;
onRequestThumbnail: (pageNumber: number) => void;
onPageClick: () => void;
}) {
const itemRef = useRef<HTMLDivElement>(null);
const hasRequested = useRef(false);
useEffect(() => {
const element = itemRef.current;
if (!element) return;
// Create intersection observer to detect when item enters viewport
const observer = new IntersectionObserver(
(entries) => {
entries.forEach(entry => {
if (entry.isIntersecting && !thumbnail && !hasRequested.current) {
hasRequested.current = true;
onRequestThumbnail(pageNumber);
}
});
},
{
root: null, // viewport
rootMargin: '100px', // Load thumbnails slightly before they enter viewport
threshold: 0.01
}
);
observer.observe(element);
return () => {
observer.disconnect();
};
if (!thumbnail && !hasRequested.current) {
hasRequested.current = true;
onRequestThumbnail(pageNumber);
}
}, [pageNumber, thumbnail, onRequestThumbnail]);
return (
<div
ref={itemRef}
className={`pdf-page-item ${isActive ? 'active' : ''}`}
onClick={onPageClick}
>