gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-06-06 18:08:33 +02:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

lazy loading of knockout (used only in attribute dialog)

Browse Source
This commit is contained in:
zadam 2019-08-25 21:59:54 +02:00
parent 24a3f814ed
commit bbe0e9e425
3 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/public/javascripts/dialogs/attributes.js
View File

@ -4,13 +4,12 @@ import infoService from "../services/info.js";
import treeUtils from "../services/tree_utils.js"; import treeUtils from "../services/tree_utils.js";
import attributeAutocompleteService from "../services/attribute_autocomplete.js"; import attributeAutocompleteService from "../services/attribute_autocomplete.js";
import utils from "../services/utils.js"; import utils from "../services/utils.js";
import libraryLoader from "../services/library_loader.js";
const $dialog = $("#attributes-dialog"); const $dialog = $("#attributes-dialog");
const $saveAttributesButton = $("#save-attributes-button"); const $saveAttributesButton = $("#save-attributes-button");
const $ownedAttributesBody = $('#owned-attributes-table tbody'); const $ownedAttributesBody = $('#owned-attributes-table tbody');
const attributesModel = new AttributesModel();
function AttributesModel() { function AttributesModel() {
const self = this; const self = this;
@ -254,9 +253,15 @@ function AttributesModel() {
} }
} }
let attributesModel;
export async function showDialog() { export async function showDialog() {
utils.closeActiveDialog(); utils.closeActiveDialog();
await libraryLoader.requireLibrary(libraryLoader.KNOCKOUT);
attributesModel = new AttributesModel();
// lazily apply bindings on first use // lazily apply bindings on first use
if (!ko.dataFor($dialog[0])) { if (!ko.dataFor($dialog[0])) {
ko.applyBindings(attributesModel, $dialog[0]); ko.applyBindings(attributesModel, $dialog[0]);

5
src/public/javascripts/services/library_loader.js
View File

@ -49,6 +49,8 @@ const PRINT_THIS = {js: ["libraries/printThis.js"]};
const SORTABLE = {js: ["libraries/sortable.min.js"]}; const SORTABLE = {js: ["libraries/sortable.min.js"]};
const KNOCKOUT = {js: ["libraries/knockout.min.js"]};
async function requireLibrary(library) { async function requireLibrary(library) {
if (library.css) { if (library.css) {
library.css.map(cssUrl => cssLoader.requireCss(cssUrl)); library.css.map(cssUrl => cssLoader.requireCss(cssUrl));
@ -85,5 +87,6 @@ export default {
RELATION_MAP, RELATION_MAP,
LINK_MAP, LINK_MAP,
PRINT_THIS, PRINT_THIS,
SORTABLE SORTABLE,
KNOCKOUT
} }

2
src/views/desktop.ejs
View File

@ -205,8 +205,6 @@
<script src="libraries/jquery.hotkeys.js"></script> <script src="libraries/jquery.hotkeys.js"></script>
<script src="libraries/jquery.fancytree.hotkeys.js"></script> <script src="libraries/jquery.fancytree.hotkeys.js"></script>
<script src="libraries/knockout.min.js"></script>
<script src="libraries/autocomplete.jquery.min.js"></script> <script src="libraries/autocomplete.jquery.min.js"></script>
<script src="libraries/dayjs.min.js"></script> <script src="libraries/dayjs.min.js"></script>