From bb2a08091675d29d14f32a47afb043a6d0128414 Mon Sep 17 00:00:00 2001 From: zhangyangrui Date: Fri, 23 Jan 2026 10:00:09 +0800 Subject: [PATCH] fix: address PR review comments --- README.md | 2 +- apps/server/src/routes/api/minimax.ts | 2 -- apps/server/src/services/llm/providers/minimax_service.ts | 5 +++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 6af44d66a..e86c6c742 100644 --- a/README.md +++ b/README.md @@ -203,4 +203,4 @@ pnpm run --filter desktop electron-forge:make --arch=x64 --platform=win32 * [Sarah Hussein](https://github.com/Sarah-Hussein) – 应用图标设计 * [nriver](https://github.com/nriver) – 国际化贡献 * [Thomas Frei](https://github.com/thfrei) – Canvas 初始实现 -* [antoniotejada](https://github.com/nriver) – 语法高亮小组件初始实现 +* [antoniotejada](https://github.com/antoniotejada) – 语法高亮小组件初始实现 diff --git a/apps/server/src/routes/api/minimax.ts b/apps/server/src/routes/api/minimax.ts index e9ebdbc54..bf3b72186 100644 --- a/apps/server/src/routes/api/minimax.ts +++ b/apps/server/src/routes/api/minimax.ts @@ -38,8 +38,6 @@ import { PROVIDER_CONSTANTS } from '../../services/llm/constants/provider_consta */ async function listModels(req: Request, res: Response) { try { - const { baseUrl } = req.query; - const apiKey = await options.getOption('minimaxApiKey'); if (!apiKey) { diff --git a/apps/server/src/services/llm/providers/minimax_service.ts b/apps/server/src/services/llm/providers/minimax_service.ts index 459fedbe9..fce31ae7e 100644 --- a/apps/server/src/services/llm/providers/minimax_service.ts +++ b/apps/server/src/services/llm/providers/minimax_service.ts @@ -74,11 +74,12 @@ export class MiniMaxService extends BaseAIService { // Add tool instructions to system prompt if tools are enabled const willUseTools = opts.tools && opts.tools.length > 0; + let finalSystemPrompt: string; if (willUseTools && PROVIDER_PROMPTS.MINIMAX.TOOL_INSTRUCTIONS) { log.info('Adding tool instructions to system prompt for MiniMax'); - var finalSystemPrompt = `${systemPrompt}\n\n${PROVIDER_PROMPTS.MINIMAX.TOOL_INSTRUCTIONS}`; + finalSystemPrompt = `${systemPrompt}\n\n${PROVIDER_PROMPTS.MINIMAX.TOOL_INSTRUCTIONS}`; } else { - var finalSystemPrompt = systemPrompt; + finalSystemPrompt = systemPrompt; } // Format messages for MiniMax API (Anthropic-compatible format)