From b2436324830b0606f02d1b5b53f117ef419c7ae9 Mon Sep 17 00:00:00 2001
From: azivner <adam.zivner@gmail.com>
Date: Thu, 7 Jun 2018 20:18:46 -0400
Subject: [PATCH] usability improvements to autocomplete ("no results" etc.),
 needs refactoring

---
 src/public/javascripts/dialogs/jump_to_note.js | 13 ++++++++++++-
 src/views/index.ejs                            | 10 +++++-----
 2 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/src/public/javascripts/dialogs/jump_to_note.js b/src/public/javascripts/dialogs/jump_to_note.js
index 421724ded..36f699983 100644
--- a/src/public/javascripts/dialogs/jump_to_note.js
+++ b/src/public/javascripts/dialogs/jump_to_note.js
@@ -23,7 +23,18 @@ async function showDialog() {
         source: async function(request, response) {
             const result = await server.get('autocomplete?query=' + encodeURIComponent(request.term));
 
-            response(result);
+            if (result.length > 0) {
+                response(result);
+            }
+            else {
+                response([{
+                    label: "No results",
+                    value: "No results"
+                }]);
+            }
+        },
+        focus: function(event, ui) {
+            return $(ui.item).val() !== 'No results';
         },
         minLength: 2
     });
diff --git a/src/views/index.ejs b/src/views/index.ejs
index 0efe09cf4..1ed14a1ed 100644
--- a/src/views/index.ejs
+++ b/src/views/index.ejs
@@ -57,7 +57,7 @@
       </div>
 
       <div style="grid-area: left-pane; display: flex; flex-direction: column;" class="hide-toggle">
-        <div style="display: flex; justify-content: space-around; padding: 10px 0 10px 0; margin: 0 20px 0 20px; border: 1px solid #ccc;">
+        <div style="display: flex; justify-content: space-around; padding: 10px 0 10px 0; margin: 0 10px 0 16px; border: 1px solid #ccc;">
           <a id="create-top-level-note-button" title="Create new top level note" class="icon-action"
              style="background: url('/images/icons/file-plus.png')"></a>
 
@@ -281,7 +281,7 @@
       <input id="recent-notes-search-input" class="form-control"/>
     </div>
 
-    <div id="add-link-dialog" title="Add link" style="display: none;">
+    <div id="add-link-dialog" title="Add note link" style="display: none;">
       <form id="add-link-form">
         <div id="add-link-type-div" class="radio">
           <label title="Add HTML link to the selected note at cursor in current note">
@@ -299,7 +299,7 @@
 
         <div class="form-group">
           <label for="note-autocomplete">Note</label>
-          <input id="note-autocomplete" style="width: 100%;">
+          <input id="note-autocomplete" placeholder="search for note by its name" style="width: 100%;">
         </div>
 
         <div class="form-group" id="add-link-title-form-group">
@@ -312,7 +312,7 @@
           <input id="clone-prefix" style="width: 100%;">
         </div>
 
-        <button class="btn btn-sm">Add link</button>
+        <button class="btn btn-sm">Add note link</button>
       </form>
     </div>
 
@@ -320,7 +320,7 @@
       <form id="jump-to-note-form">
         <div class="form-group">
           <label for="jump-to-note-autocomplete">Note</label>
-          <input id="jump-to-note-autocomplete" style="width: 100%;">
+          <input id="jump-to-note-autocomplete" placeholder="search for note by its name" style="width: 100%;">
         </div>
 
         <div style="display: flex; justify-content: space-between;">