gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-12-06 23:44:25 +01:00
Code Issues Actions 30 Packages Projects Releases Wiki Activity

refactor(note-create): replace 'at' with 'with'

Browse Source
This commit is contained in:
Jakob Schlanstedt 2025-10-28 18:33:48 +01:00
parent 71009bddc7
commit b0fdb9fef2
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
apps/client/src/services/note_create.ts
View File

@ -78,10 +78,10 @@ export type CreateNoteOpts = {
/* /*
* Defines options for creating a note at a specific path. * Defines options for creating a note at a specific path.
* Serves as a base (not exported) for "into", "before", and "after" variants, * Serves as a base for "into", "before", and "after" variants,
* sharing common URL-related fields. * sharing common URL-related fields.
*/ */
type CreateNoteAtUrlOpts = CreateNoteOpts & { type CreateNoteWithUrlOpts = CreateNoteOpts & {
// `Url` may refer to either parentNotePath or parentNoteId. // `Url` may refer to either parentNotePath or parentNoteId.
// The vocabulary is inspired by existing function getNoteIdFromUrl. // The vocabulary is inspired by existing function getNoteIdFromUrl.
parentNoteUrl: string; parentNoteUrl: string;
@ -90,9 +90,9 @@ type CreateNoteAtUrlOpts = CreateNoteOpts & {
targetBranchId: string; targetBranchId: string;
} }
export type CreateNoteIntoUrlOpts = CreateNoteAtUrlOpts; export type CreateNoteIntoUrlOpts = CreateNoteWithUrlOpts;
export type CreateNoteBeforeUrlOpts = CreateNoteAtUrlOpts; export type CreateNoteBeforeUrlOpts = CreateNoteWithUrlOpts;
export type CreateNoteAfterUrlOpts = CreateNoteAtUrlOpts; export type CreateNoteAfterUrlOpts = CreateNoteWithUrlOpts;
type NeverDefineParentNoteUrlRule = { type NeverDefineParentNoteUrlRule = {
parentNoteUrl?: never; parentNoteUrl?: never;
@ -132,9 +132,9 @@ async function createNote(
return createNoteIntoInbox(resolvedOptions as CreateNoteIntoInboxOpts); return createNoteIntoInbox(resolvedOptions as CreateNoteIntoInboxOpts);
} }
return createNoteAtNote( return createNoteWithUrl(
resolvedOptions.target as "into" | "after" | "before", resolvedOptions.target as "into" | "after" | "before",
resolvedOptions as CreateNoteAtUrlOpts resolvedOptions as CreateNoteWithUrlOpts
); );
} }
@ -173,9 +173,9 @@ async function promptForType(
* @param options - Note creation options * @param options - Note creation options
* @returns A promise resolving with the created note and its branch. * @returns A promise resolving with the created note and its branch.
*/ */
async function createNoteAtNote( async function createNoteWithUrl(
target: "into" | "after" | "before", target: "into" | "after" | "before",
options: CreateNoteAtUrlOpts options: CreateNoteWithUrlOpts
): Promise<{ note: FNote | null; branch: FBranch | undefined }> { ): Promise<{ note: FNote | null; branch: FBranch | undefined }> {
options = Object.assign( options = Object.assign(
{ {
@ -270,7 +270,7 @@ async function createNoteIntoInbox(
inboxNote.isProtected && protectedSessionHolder.isProtectedSessionAvailable(); inboxNote.isProtected && protectedSessionHolder.isProtectedSessionAvailable();
} }
const result = await createNoteAtNote("into", const result = await createNoteWithUrl("into",
{ {
...options, ...options,
parentNoteUrl: inboxNote.noteId, parentNoteUrl: inboxNote.noteId,