gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-03-01 14:22:32 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

disallow removing last tab because of frequent race conditions when done too quickly

Browse Source
This commit is contained in:
zadam 2021-10-28 22:27:21 +02:00
parent 5209583a73
commit ab7d121290
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/public/app/services/tab_manager.js
View File

@ -299,6 +299,16 @@ export default class TabManager extends Component {
async removeNoteContext(ntxId) { async removeNoteContext(ntxId) {
const noteContextToRemove = this.getNoteContextById(ntxId); const noteContextToRemove = this.getNoteContextById(ntxId);
if (noteContextToRemove.isMainContext()) {
// forbid removing last main note context
// this was previously allowed (was replaced with empty tab) but this proved to be prone to race conditions
const mainNoteContexts = this.getNoteContexts().filter(nc => nc.isMainContext());
if (mainNoteContexts.length === 1) {
return;
}
}
// close dangling autocompletes after closing the tab // close dangling autocompletes after closing the tab
$(".aa-input").autocomplete("close"); $(".aa-input").autocomplete("close");