From a9a9edf6584440af2ce5a27f776048dbb827d22d Mon Sep 17 00:00:00 2001 From: zadam Date: Fri, 2 Oct 2020 21:44:21 +0200 Subject: [PATCH] clear any event listener added in previous invocation of this function --- src/public/app/dialogs/jump_to_note.js | 2 -- src/public/app/services/note_autocomplete.js | 6 ++++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/public/app/dialogs/jump_to_note.js b/src/public/app/dialogs/jump_to_note.js index 378b6876d..172c9f2ff 100644 --- a/src/public/app/dialogs/jump_to_note.js +++ b/src/public/app/dialogs/jump_to_note.js @@ -13,8 +13,6 @@ export async function showDialog() { utils.openDialog($dialog); noteAutocompleteService.initNoteAutocomplete($autoComplete, { hideGoToSelectedNoteButton: true }) - // clear any event listener added in previous invocation of this function - .off('autocomplete:noteselected') .on('autocomplete:noteselected', function(event, suggestion, dataset) { if (!suggestion.notePath) { return false; diff --git a/src/public/app/services/note_autocomplete.js b/src/public/app/services/note_autocomplete.js index cd20f1a8b..29918c271 100644 --- a/src/public/app/services/note_autocomplete.js +++ b/src/public/app/services/note_autocomplete.js @@ -67,6 +67,9 @@ function showRecentNotes($el) { function initNoteAutocomplete($el, options) { if ($el.hasClass("note-autocomplete-input") || utils.isMobile()) { + // clear any event listener added in previous invocation of this function + $el.off('autocomplete:noteselected'); + return $el; } @@ -157,6 +160,9 @@ function initNoteAutocomplete($el, options) { } }); + // clear any event listener added in previous invocation of this function + $el.off('autocomplete:noteselected'); + return $el; }