From 995ebbf57776135c3f94ee01da3a9fd60fe86f4a Mon Sep 17 00:00:00 2001 From: zadam Date: Sat, 30 Nov 2019 10:41:53 +0100 Subject: [PATCH] removed foreign keys PRAGMAs since foreign key constraints are not used anymore --- src/services/migration.js | 7 ------- src/services/sql_init.js | 2 -- 2 files changed, 9 deletions(-) diff --git a/src/services/migration.js b/src/services/migration.js index 2b93f0064..4c82a36d6 100644 --- a/src/services/migration.js +++ b/src/services/migration.js @@ -43,9 +43,6 @@ async function migrate() { try { log.info("Attempting migration to version " + mig.dbVersion); - // needs to happen outside of the transaction (otherwise it's a NO-OP) - await sql.execute("PRAGMA foreign_keys = OFF"); - await sql.transactional(async () => { if (mig.type === 'sql') { const migrationSql = fs.readFileSync(resourceDir.MIGRATIONS_DIR + "/" + mig.file).toString('utf8'); @@ -76,10 +73,6 @@ async function migrate() { utils.crash(); } - finally { - // make sure foreign keys are enabled even if migration script disables them - await sql.execute("PRAGMA foreign_keys = ON"); - } } if (await sqlInit.isDbUpToDate()) { diff --git a/src/services/sql_init.js b/src/services/sql_init.js index 45f8272a1..7e81d2d02 100644 --- a/src/services/sql_init.js +++ b/src/services/sql_init.js @@ -57,8 +57,6 @@ async function initDbConnection() { return; } - await sql.execute("PRAGMA foreign_keys = ON"); - const currentDbVersion = await getDbVersion(); if (currentDbVersion > appInfo.dbVersion) {