gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-03-01 14:22:32 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix broken reference consistency check

Browse Source 
If a branch was identified with a missing parent, the branch would be
moved to root. However, the ID of the branch would be changed as a
result of that, and this resulted in the creation of a new branch
instead of updating the old one. Deleting the old one first solves the
issue.
This commit is contained in:
Elian Doran 2023-02-05 01:12:13 +02:00
parent e7c6d912a4
commit 92f586486f
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/services/consistency_checks.js
View File

@ -148,13 +148,20 @@ class ConsistencyChecks {
AND notes.noteId IS NULL`, AND notes.noteId IS NULL`,
({branchId, parentNoteId}) => { ({branchId, parentNoteId}) => {
if (this.autoFix) { if (this.autoFix) {
const branch = becca.getBranch(branchId); // Delete the old branch and recreate it with root as parent.
branch.parentNoteId = 'root'; const oldBranch = becca.getBranch(branchId);
branch.save(); const noteId = oldBranch.noteId;
oldBranch.markAsDeleted("missing-parent");
const newBranch = new Branch({
parentNoteId: 'root',
noteId: noteId,
prefix: 'recovered'
}).save();
this.reloadNeeded = true; this.reloadNeeded = true;
logFix(`Branch '${branchId}' was set to root parent since it was referencing missing parent note '${parentNoteId}'`); logFix(`Branch '${branchId}' was was missing parent note '${parentNoteId}', so it was deleted. ${newBranch.branchId} was created in the root instead.`);
} else { } else {
logError(`Branch '${branchId}' references missing parent note '${parentNoteId}'`); logError(`Branch '${branchId}' references missing parent note '${parentNoteId}'`);
} }