gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-11-07 15:09:01 +01:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

feat(react/ribbon): reintroduce checkbox collection properties

Browse Source
This commit is contained in:
Elian Doran 2025-08-23 23:32:12 +03:00
parent ea1397de63
commit 927ebcbec9
No known key found for this signature in database
3 changed files with 17 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
apps/client/src/widgets/ribbon/CollectionPropertiesTab.tsx
View File

@ -4,11 +4,12 @@ import { ViewTypeOptions } from "../../services/note_list_renderer";
import FormSelect from "../react/FormSelect"; import FormSelect from "../react/FormSelect";
import { TabContext } from "./ribbon-interface"; import { TabContext } from "./ribbon-interface";
import { mapToKeyValueArray } from "../../services/utils"; import { mapToKeyValueArray } from "../../services/utils";
import { useNoteLabel } from "../react/hooks"; import { useNoteLabel, useNoteLabelBoolean } from "../react/hooks";
import { bookPropertiesConfig, BookProperty, ButtonProperty } from "../ribbon_widgets/book_properties_config"; import { bookPropertiesConfig, BookProperty, ButtonProperty, CheckBoxProperty } from "../ribbon_widgets/book_properties_config";
import Button from "../react/Button"; import Button from "../react/Button";
import { ParentComponent } from "../react/react_utils"; import { ParentComponent } from "../react/react_utils";
import FNote from "../../entities/fnote"; import FNote from "../../entities/fnote";
import FormCheckbox from "../react/FormCheckbox";
const VIEW_TYPE_MAPPINGS: Record<ViewTypeOptions, string> = { const VIEW_TYPE_MAPPINGS: Record<ViewTypeOptions, string> = {
grid: t("book_properties.grid"), grid: t("book_properties.grid"),
@ -63,6 +64,8 @@ function mapPropertyView({ note, property }: { note: FNote, property: BookProper
switch (property.type) { switch (property.type) {
case "button": case "button":
return <ButtonPropertyView note={note} property={property} /> return <ButtonPropertyView note={note} property={property} />
case "checkbox":
return <CheckboxPropertyView note={note} property={property} />
} }
} }
@ -82,3 +85,14 @@ function ButtonPropertyView({ note, property }: { note: FNote, property: ButtonP
}} }}
/> />
} }
function CheckboxPropertyView({ note, property }: { note: FNote, property: CheckBoxProperty }) {
const [ value, setValue ] = useNoteLabelBoolean(note, property.bindToLabel);
return (
<FormCheckbox
label={property.label}
currentValue={value} onChange={setValue}
/>
)
}

17
apps/client/src/widgets/ribbon_widgets/book_properties.ts
View File

@ -56,23 +56,6 @@ export default class BookPropertiesWidget extends NoteContextAwareWidget {
return $container; return $container;
} }
switch (property.type) { switch (property.type) {
case "checkbox":
const $label = $("<label>").text(property.label);
const $checkbox = $("<input>", {
type: "checkbox",
class: "form-check-input",
});
$checkbox.on("change", () => {
if ($checkbox.prop("checked")) {
attributes.setLabel(note.noteId, property.bindToLabel);
} else {
attributes.removeOwnedLabelByName(note, property.bindToLabel);
}
});
$checkbox.prop("checked", note.hasOwnedLabel(property.bindToLabel));
$label.prepend($checkbox);
$container.append($label);
break;
case "number": case "number":
const $numberInput = $("<input>", { const $numberInput = $("<input>", {
type: "number", type: "number",

2
apps/client/src/widgets/ribbon_widgets/book_properties_config.ts
View File

@ -9,7 +9,7 @@ interface BookConfig {
properties: BookProperty[]; properties: BookProperty[];
} }
interface CheckBoxProperty { export interface CheckBoxProperty {
type: "checkbox", type: "checkbox",
label: string; label: string;
bindToLabel: string bindToLabel: string