From 88d90fdedd20b002fcdff8ae7c38a9e88fc4001b Mon Sep 17 00:00:00 2001
From: Elian Doran <contact@eliandoran.me>
Date: Tue, 28 Oct 2025 18:23:11 +0200
Subject: [PATCH] fix(export/share): favicon working only on top-level

---
 apps/server/src/share/content_renderer.ts   | 5 ++++-
 packages/share-theme/src/templates/page.ejs | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/apps/server/src/share/content_renderer.ts b/apps/server/src/share/content_renderer.ts
index fd45d27da..60ff07967 100644
--- a/apps/server/src/share/content_renderer.ts
+++ b/apps/server/src/share/content_renderer.ts
@@ -81,6 +81,7 @@ export function renderNoteForExport(note: BNote, parentBranch: BBranch, basePath
             `${basePath}assets/scripts.js`
         ],
         logoUrl: `${basePath}icon-color.svg`,
+        faviconUrl: `${basePath}favicon.ico`,
         ancestors,
         isStatic: true
     });
@@ -128,7 +129,8 @@ export function renderNoteContent(note: SNote) {
         jsToLoad,
         logoUrl,
         ancestors,
-        isStatic: false
+        isStatic: false,
+        faviconUrl: note.hasRelation("shareFavicon") ? `api/notes/${note.getRelationValue("shareFavicon")}/download` : `../favicon.ico`
     });
 }
 
@@ -140,6 +142,7 @@ interface RenderArgs {
     logoUrl: string;
     ancestors: string[];
     isStatic: boolean;
+    faviconUrl: string;
 }
 
 function renderNoteContentInternal(note: SNote | BNote, renderArgs: RenderArgs) {
diff --git a/packages/share-theme/src/templates/page.ejs b/packages/share-theme/src/templates/page.ejs
index 3d29bbf80..782a88dbf 100644
--- a/packages/share-theme/src/templates/page.ejs
+++ b/packages/share-theme/src/templates/page.ejs
@@ -29,7 +29,7 @@
     <meta charset="utf-8">
     <meta name="viewport" content="width=device-width, initial-scale=1">
 
-    <link rel="shortcut icon" href="<% if (note.hasRelation("shareFavicon")) { %>api/notes/<%= note.getRelation("shareFavicon").value %>/download<% } else { %>../favicon.ico<% } %>">
+    <link rel="shortcut icon" href="<%= faviconUrl %>">
     <% for (const url of cssToLoad) { %>
         <link href="<%= url %>" rel="stylesheet">
     <% } %>