gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-10-20 15:19:01 +02:00
Code Issues Actions 19 Packages Projects Releases Wiki Activity

fix(react/dialogs): bulk actions not working in search notes

Browse Source
This commit is contained in:
Elian Doran 2025-08-10 14:06:14 +03:00
parent d3519b3059
commit 861374bb87
No known key found for this signature in database
2 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
apps/client/src/widgets/react/ReactBasicWidget.tsx
View File

@ -8,14 +8,25 @@ export default abstract class ReactBasicWidget extends BasicWidget {
abstract get component(): JSX.Element;
doRender() {
const renderContainer = new DocumentFragment();
render((
<ParentComponent.Provider value={this}>
{this.component}
</ParentComponent.Provider>
), renderContainer);
this.$widget = $(renderContainer.firstChild as HTMLElement);
doRender() {
this.$widget = renderReactWidget(this, this.component);
}
}
/**
* Renders a React component and returns the corresponding DOM element wrapped in JQuery.
*
* @param parentComponent the parent Trilium component for the component to be able to handle events.
* @param el the JSX element to render.
* @returns the rendered wrapped DOM element.
*/
export function renderReactWidget(parentComponent: Component, el: JSX.Element) {
const renderContainer = new DocumentFragment();
render((
<ParentComponent.Provider value={parentComponent}>
{el}
</ParentComponent.Provider>
), renderContainer);
return $(renderContainer.firstChild as HTMLElement);
}

3
apps/client/src/widgets/ribbon_widgets/search_definition.ts
View File

@ -19,6 +19,7 @@ import bulkActionService from "../../services/bulk_action.js";
import { Dropdown } from "bootstrap";
import type FNote from "../../entities/fnote.js";
import type { AttributeType } from "../../entities/fattribute.js";
import { renderReactWidget } from "../react/ReactBasicWidget.jsx";
const TPL = /*html*/`
<div class="search-definition-widget">
@ -306,7 +307,7 @@ export default class SearchDefinitionWidget extends NoteContextAwareWidget {
const actions = bulkActionService.parseActions(this.note);
const renderedEls = actions
.map((action) => action.render())
.map((action) => renderReactWidget(this, action.doRender()))
.filter((e) => e) as JQuery<HTMLElement>[];
this.$actionOptions.empty().append(...renderedEls);