gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-10-21 07:38:53 +02:00
Code Issues Actions 17 Packages Projects Releases Wiki Activity

fix(react/dialogs): listener leak in modal

Browse Source
This commit is contained in:
Elian Doran 2025-08-04 19:54:59 +03:00
parent cb650b70cb
commit 83fb62d4df
No known key found for this signature in database
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
apps/client/src/widgets/react/Modal.tsx
View File

@ -28,14 +28,23 @@ export default function Modal({ children, className, size, title, footer, onShow
if (onShown || onHidden) { if (onShown || onHidden) {
useEffect(() => { useEffect(() => {
const modalElement = modalRef.current; const modalElement = modalRef.current;
if (modalElement) { if (!modalElement) {
return;
}
if (onShown) { if (onShown) {
modalElement.addEventListener("shown.bs.modal", onShown); modalElement.addEventListener("shown.bs.modal", onShown);
} }
if (onHidden) { if (onHidden) {
modalElement.addEventListener("hidden.bs.modal", onHidden); modalElement.addEventListener("hidden.bs.modal", onHidden);
} }
return () => {
if (onShown) {
modalElement.removeEventListener("shown.bs.modal", onShown);
} }
if (onHidden) {
modalElement.removeEventListener("hidden.bs.modal", onHidden);
}
};
}); });
} }