defensive copies of owned attrs

This commit is contained in:
zadam 2023-07-17 22:56:36 +02:00
parent bc8f531b33
commit 83049c95c3
3 changed files with 2 additions and 6 deletions

View File

@ -18,7 +18,7 @@ module.exports = () => {
if (noteId.startsWith("_")) { // is "named" note if (noteId.startsWith("_")) { // is "named" note
const note = becca.getNote(noteId); const note = becca.getNote(noteId);
for (const attr of note.getOwnedAttributes()) { for (const attr of note.getOwnedAttributes().slice()) {
attr.markAsDeleted("0212__delete_all_attributes_of_named_notes"); attr.markAsDeleted("0212__delete_all_attributes_of_named_notes");
} }
} }

View File

@ -274,8 +274,6 @@ class AbstractBeccaEntity {
[this.dateModified, entityId]); [this.dateModified, entityId]);
} }
console.trace("DELETE");
log.info(`Marking ${entityName} ${entityId} as deleted`); log.info(`Marking ${entityName} ${entityId} as deleted`);
this.addEntityChange(true); this.addEntityChange(true);
@ -293,8 +291,6 @@ class AbstractBeccaEntity {
WHERE ${this.constructor.primaryKeyName} = ?`, WHERE ${this.constructor.primaryKeyName} = ?`,
[this.utcDateModified, entityId]); [this.utcDateModified, entityId]);
console.trace("DELETE");
log.info(`Marking ${entityName} ${entityId} as deleted`); log.info(`Marking ${entityName} ${entityId} as deleted`);
this.addEntityChange(true); this.addEntityChange(true);

View File

@ -191,7 +191,7 @@ class BBranch extends AbstractBeccaEntity {
this.becca.notes[note.noteId].isBeingDeleted = true; this.becca.notes[note.noteId].isBeingDeleted = true;
for (const attribute of note.getOwnedAttributes()) { for (const attribute of note.getOwnedAttributes().slice()) {
attribute.markAsDeleted(deleteId); attribute.markAsDeleted(deleteId);
} }