From 8128a8192ae0894033df53fad00bb59f024f43a5 Mon Sep 17 00:00:00 2001 From: Elian Doran Date: Thu, 5 Mar 2026 19:28:52 +0200 Subject: [PATCH] refactor(ckeditor): address requested changes --- packages/ckeditor5/src/utils.ts | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/packages/ckeditor5/src/utils.ts b/packages/ckeditor5/src/utils.ts index 5bdac16f0a..4ed648d114 100644 --- a/packages/ckeditor5/src/utils.ts +++ b/packages/ckeditor5/src/utils.ts @@ -1,24 +1,15 @@ -import { DifferItemAttribute, ModelDocumentFragment, ModelElement, ModelNode } from "ckeditor5"; -import { CKTextEditor } from "src"; - -function isHeadingElement(node: ModelElement | ModelNode | ModelDocumentFragment | null): node is ModelElement { - return !!node - && typeof (node as any).is === "function" - && (node as any).is("element") - && typeof (node as any).name === "string" - && (node as any).name.startsWith("heading"); -} +import type { DifferItemAttribute, Editor, ModelDocumentFragment, ModelElement, ModelNode } from "ckeditor5"; function hasHeadingAncestor(node: ModelElement | ModelNode | ModelDocumentFragment | null): boolean { let current: ModelElement | ModelNode | ModelDocumentFragment | null = node; while (current) { - if (isHeadingElement(current)) return true; + if (!!current && current.is('element') && (current as ModelElement).name.startsWith("heading")) return true; current = current.parent; } return false; } -export function attributeChangeAffectsHeading(change: DifferItemAttribute, editor: CKTextEditor): boolean { +export function attributeChangeAffectsHeading(change: DifferItemAttribute, editor: Editor): boolean { if (change.type !== "attribute") return false; // Fast checks on range boundaries