From 7f909fa09854780d2238d837bc268314e8a92572 Mon Sep 17 00:00:00 2001 From: Elian Doran Date: Sun, 23 Nov 2025 16:28:57 +0200 Subject: [PATCH] chore(promoted_attributes): address review --- apps/client/src/widgets/PromotedAttributes.css | 3 ++- apps/client/src/widgets/PromotedAttributes.tsx | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/client/src/widgets/PromotedAttributes.css b/apps/client/src/widgets/PromotedAttributes.css index 2e1cab3dd..6e3c7795d 100644 --- a/apps/client/src/widgets/PromotedAttributes.css +++ b/apps/client/src/widgets/PromotedAttributes.css @@ -15,12 +15,13 @@ body.mobile .promoted-attributes-widget { flex-wrap: wrap; display: table; } + .promoted-attribute-cell { display: flex; align-items: center; margin: 10px; - display: table-row; } + .promoted-attribute-cell > label { user-select: none; font-weight: bold; diff --git a/apps/client/src/widgets/PromotedAttributes.tsx b/apps/client/src/widgets/PromotedAttributes.tsx index b7ffca060..f24cd7d60 100644 --- a/apps/client/src/widgets/PromotedAttributes.tsx +++ b/apps/client/src/widgets/PromotedAttributes.tsx @@ -180,7 +180,7 @@ function LabelInput({ inputId, ...props }: CellProps & { inputId: string }) { setupTextLabelAutocomplete(el as HTMLInputElement, valueAttr, onChangeListener); } } - }, []); + }, [ inputId, valueAttr, onChangeListener ]); switch (definition.labelType) { case "number": {