feat(views/table): basic editing of columns (rename not supported)

apps/client/src/components/app_context.ts

@@ -284,6 +284,7 @@ export type CommandMappings = {
         parentNotePath?: string;
     };
     addNewTableColumn: CommandData & {
+        columnToEdit?: ColumnComponent;
         referenceColumn?: ColumnComponent;
         direction?: "before" | "after";
     };

apps/client/src/translations/en/translation.json

@@ -1955,7 +1955,8 @@
     "row-insert-below": "Insert row below",
     "row-insert-child": "Insert child note",
     "add-column-to-the-left": "Add column to the left",
-    "add-column-to-the-right": "Add column to the right"
+    "add-column-to-the-right": "Add column to the right",
+    "edit-column": "Edit column"
   },
   "book_properties_config": {
     "hide-weekends": "Hide weekends",

apps/client/src/widgets/view_widgets/table_view/col_editing.ts

@@ -25,12 +25,21 @@ export default class TableColumnEditing extends Component {
         this.parentNote = parentNote;
     }
 
-    addNewTableColumnCommand({ referenceColumn, direction }: EventData<"addNewTableColumn">) {
+    addNewTableColumnCommand({ referenceColumn, columnToEdit, direction }: EventData<"addNewTableColumn">) {
-        const attr: Attribute = {
+        let attr: Attribute | undefined;
+
+        if (columnToEdit) {
+            attr = this.getAttributeFromField(columnToEdit.getField());
+            console.log("Built ", attr);
+        }
+
+        if (!attr) {
+            attr = {
                 type: "label",
                 name: "label:myLabel",
                 value: "promoted,single,text"
             };
+        }
 
         if (referenceColumn && this.api) {
             this.newAttributePosition = this.api.getColumns().indexOf(referenceColumn);
@@ -47,7 +56,7 @@ export default class TableColumnEditing extends Component {
             allAttributes: [ attr ],
             isOwned: true,
             x: 0,
-            y: 75,
+            y: 150,
             focus: "name"
         });
     }
@@ -62,7 +71,7 @@ export default class TableColumnEditing extends Component {
         }
 
         const { name, value } = this.newAttribute;
-        attributes.addLabel(this.parentNote.noteId, name, value, true);
+        attributes.setLabel(this.parentNote.noteId, name, value);
     }
 
     getNewAttributePosition() {
@@ -73,4 +82,23 @@ export default class TableColumnEditing extends Component {
         this.newAttributePosition = 0;
     }
 
+    getFAttributeFromField(field: string) {
+        const [ type, name ] = field.split(".", 2);
+        const attrName = `${type.replace("s", "")}:${name}`;
+        return this.parentNote.getLabel(attrName);
     }
+
+    getAttributeFromField(field: string) {
+        const fAttribute = this.getFAttributeFromField(field);
+        if (fAttribute) {
+            return {
+                name: fAttribute.name,
+                value: fAttribute.value,
+                type: fAttribute.type
+            };
+        }
+        return undefined;
+    }
+
+}
+

apps/client/src/widgets/view_widgets/table_view/context_menu.ts

@@ -86,6 +86,13 @@ function showColumnContextMenu(_e: UIEvent, column: ColumnComponent, tabulator:
                     referenceColumn: column
                 })
             },
+            {
+                title: t("table_view.edit-column"),
+                uiIcon: "bx bx-edit",
+                handler: () => getParentComponent(e)?.triggerCommand("addNewTableColumn", {
+                    columnToEdit: column
+                })
+            },
             {
                 title: t("table_view.add-column-to-the-right"),
                 uiIcon: "bx bx-horizontal-right",