From 75e88c69bd0648fb2f587832b18873153dc3db45 Mon Sep 17 00:00:00 2001 From: Elian Doran Date: Sat, 24 Jan 2026 12:12:07 +0200 Subject: [PATCH] fix(web-clipper): createLink not defined in popup --- apps/web-clipper/entrypoints/content/index.js | 14 +------------- apps/web-clipper/entrypoints/popup/index.html | 1 - apps/web-clipper/entrypoints/popup/popup.js | 2 +- apps/web-clipper/utils.js | 12 ++++++++++++ 4 files changed, 14 insertions(+), 15 deletions(-) diff --git a/apps/web-clipper/entrypoints/content/index.js b/apps/web-clipper/entrypoints/content/index.js index 973172b4e..e5c364247 100644 --- a/apps/web-clipper/entrypoints/content/index.js +++ b/apps/web-clipper/entrypoints/content/index.js @@ -1,4 +1,4 @@ -import { getBaseUrl, getPageLocationOrigin, randomString } from "../../utils.js"; +import { createLink, getBaseUrl, getPageLocationOrigin, randomString } from "../../utils.js"; import Readability from "../../lib/Readability.js"; export default defineContentScript({ @@ -237,18 +237,6 @@ export default defineContentScript({ return images; } - function createLink(clickAction, text, color = "lightskyblue") { - const link = document.createElement('a'); - link.href = "javascript:"; - link.style.color = color; - link.appendChild(document.createTextNode(text)); - link.addEventListener("click", () => { - browser.runtime.sendMessage(null, clickAction) - }); - - return link - } - async function prepareMessageResponse(message) { console.info('Message: ' + message.name); diff --git a/apps/web-clipper/entrypoints/popup/index.html b/apps/web-clipper/entrypoints/popup/index.html index 7bd985801..0479588e7 100644 --- a/apps/web-clipper/entrypoints/popup/index.html +++ b/apps/web-clipper/entrypoints/popup/index.html @@ -50,7 +50,6 @@ - diff --git a/apps/web-clipper/entrypoints/popup/popup.js b/apps/web-clipper/entrypoints/popup/popup.js index be571e428..775a3ec0c 100644 --- a/apps/web-clipper/entrypoints/popup/popup.js +++ b/apps/web-clipper/entrypoints/popup/popup.js @@ -1,4 +1,4 @@ -console.log("Popup script loaded"); +import { createLink } from "../../utils"; async function sendMessage(message) { try { diff --git a/apps/web-clipper/utils.js b/apps/web-clipper/utils.js index aab69e12c..a69a00dba 100644 --- a/apps/web-clipper/utils.js +++ b/apps/web-clipper/utils.js @@ -26,3 +26,15 @@ export function getPageLocationOrigin() { // but for file:// protocol this is browser dependant and in particular Firefox returns "null" in this case. return location.protocol === 'file:' ? 'file://' : location.origin; } + +export function createLink(clickAction, text, color = "lightskyblue") { + const link = document.createElement('a'); + link.href = "javascript:"; + link.style.color = color; + link.appendChild(document.createTextNode(text)); + link.addEventListener("click", () => { + browser.runtime.sendMessage(null, clickAction) + }); + + return link +}