gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2026-01-12 09:34:26 +01:00
Code Issues Actions 18 Packages Projects Releases Wiki Activity

fix(client/lightweight): statements with parameters not working

Browse Source
This commit is contained in:
Elian Doran 2026-01-07 12:21:27 +02:00
parent c5803a2650
commit 724af8e103
No known key found for this signature in database
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
apps/client/src/lightweight/sql_provider.ts
View File

@ -120,7 +120,22 @@ class WasmStatement implements Statement {
// Handle single object with named parameters
if (params.length === 1 && typeof params[0] === "object" && params[0] !== null && !Array.isArray(params[0])) {
const bindings = params[0] as { [paramName: string]: BindableValue };
const inputBindings = params[0] as { [paramName: string]: BindableValue };
// SQLite WASM expects parameter names to include the prefix (@ : or $)
// better-sqlite3 automatically maps unprefixed names to @name
// We need to add the @ prefix for compatibility
const bindings: { [paramName: string]: BindableValue } = {};
for (const [key, value] of Object.entries(inputBindings)) {
// If the key already has a prefix, use it as-is
if (key.startsWith('@') || key.startsWith(':') || key.startsWith('$')) {
bindings[key] = value;
} else {
// Add @ prefix to match better-sqlite3 behavior
bindings[`@${key}`] = value;
}
}
this.stmt.bind(bindings);
} else {
// Handle positional parameters - flatten and cast to BindableValue[]

2
packages/trilium-core/src/services/sql/sql.ts
View File

@ -277,6 +277,8 @@ export class SqlService {
return null;
}
console.error(`Error executing query: ${query} with parameters ${JSON.stringify((e as any).params || [])}`);
throw e;
}