From 57f220e64c1b3e23dfd5f430aa67a6890f1c41bf Mon Sep 17 00:00:00 2001 From: Elian Doran Date: Sat, 15 Nov 2025 15:37:00 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- apps/client/src/services/attributes.ts | 2 +- apps/client/src/services/load_results.ts | 2 +- apps/client/src/widgets/collections/board/index.tsx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/client/src/services/attributes.ts b/apps/client/src/services/attributes.ts index 7fad04947..13f440c3c 100644 --- a/apps/client/src/services/attributes.ts +++ b/apps/client/src/services/attributes.ts @@ -69,7 +69,7 @@ function removeOwnedLabelByName(note: FNote, labelName: string) { * @returns `true` if an attribute was identified and removed, `false` otherwise. */ function removeOwnedRelationByName(note: FNote, relationName: string) { - const label = note.getOwnedRelation(relationName); + const relation = note.getOwnedRelation(relationName); if (label) { removeAttributeById(note.noteId, label.attributeId); return true; diff --git a/apps/client/src/services/load_results.ts b/apps/client/src/services/load_results.ts index 3e00e4a0f..899560de4 100644 --- a/apps/client/src/services/load_results.ts +++ b/apps/client/src/services/load_results.ts @@ -7,7 +7,7 @@ import type { EntityChange } from "../server_types.js"; interface NoteRow { blobId: string; dateCreated: string; - dateMOdified: string; + dateModified: string; isDeleted?: boolean; isProtected?: boolean; mime: string; diff --git a/apps/client/src/widgets/collections/board/index.tsx b/apps/client/src/widgets/collections/board/index.tsx index e34ef1225..7b939224d 100644 --- a/apps/client/src/widgets/collections/board/index.tsx +++ b/apps/client/src/widgets/collections/board/index.tsx @@ -268,7 +268,7 @@ export function TitleEditor({ currentValue, placeholder, save, dismiss, mode, is } }; - const onBlur = (newValue) => { + const onBlur = (newValue: string) => { if (!shouldDismiss.current && newValue.trim() && (newValue !== currentValue || isNewItem)) { save(newValue); dismissOnNextRefreshRef.current = true; @@ -311,6 +311,6 @@ export function TitleEditor({ currentValue, placeholder, save, dismiss, mode, is dismiss(); }} /> - ) + ); } }