From 5204ab5a7e634175b4fb2194d3bd580b68f371cc Mon Sep 17 00:00:00 2001
From: azivner <adam.zivner@gmail.com>
Date: Mon, 12 Mar 2018 20:00:19 -0400
Subject: [PATCH] refactoring of note tree

---
 src/public/images/icons/search-small.png | Bin 0 -> 354 bytes
 src/public/javascripts/note_tree.js      |  40 ++++++++++++++++-------
 2 files changed, 28 insertions(+), 12 deletions(-)
 create mode 100644 src/public/images/icons/search-small.png

diff --git a/src/public/images/icons/search-small.png b/src/public/images/icons/search-small.png
new file mode 100644
index 0000000000000000000000000000000000000000..8cb9bc669bb1d13dc893f807e0565c6d06b5cad7
GIT binary patch
literal 354
zcmeAS@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`Y)RhkE)4%caKYZ?lYt_f1s;*b
zKpodXn9)gNb_Gz7y~NYkmHiPjH=l{P>AY=+fI{y*T^vI!POrVZ(2v<sfbBtl7uO{Q
z(F<(+eJs_SjP0r%BAZxrG`qGRFnP%=(tjxAkhX$DkY7_Shi1aEwBqBjL1s67%Kpu*
z|2Oky>cOoc52BA58m&oes<yeJXyel7Z}W)H|HnazxvL)N-$}APXtd{nWUlI_;vTP4
zO?h`D#Tu6@Rxe(3gxlw$SEJ)uwOluQzGr=IH$-c$C{*z8o+Y#=aW&h)vK!Y$Zg6Kt
zvL5u^)9of`(HB_i-L&4|aHM3l`m;HYZKSRp@k^Q4dg@=i&~3x#nKAR;d#3E``CJ;h
tIqJr7!LrG-e*bXGpXh(%aOeMs{R*arEPvKTc>}%9;OXk;vd$@?2>{ipit+#e

literal 0
HcmV?d00001

diff --git a/src/public/javascripts/note_tree.js b/src/public/javascripts/note_tree.js
index acf00551e..a5a2b158e 100644
--- a/src/public/javascripts/note_tree.js
+++ b/src/public/javascripts/note_tree.js
@@ -14,10 +14,20 @@ const noteTree = (function() {
     let childToParents = {};
 
     let parentChildToNoteTreeId = {};
-    let noteIdToTitle = {};
+    let noteIdToNote = {};
 
     let hiddenInAutocomplete = {};
 
+    function getNote(noteId) {
+        const note = noteIdToNote[noteId];
+
+        if (!note) {
+            throwError("Can't find title for noteId='" + noteId + "'");
+        }
+
+        return note;
+    }
+
     function getNoteTreeId(parentNoteId, childNoteId) {
         assertArguments(parentNoteId, childNoteId);
 
@@ -31,11 +41,7 @@ const noteTree = (function() {
     function getNoteTitle(noteId, parentNoteId = null) {
         assertArguments(noteId);
 
-        let title = noteIdToTitle[noteId];
-
-        if (!title) {
-            throwError("Can't find title for noteId='" + noteId + "'");
-        }
+        let title = getNote(noteId).title;
 
         if (parentNoteId !== null) {
             const noteTreeId = getNoteTreeId(parentNoteId, noteId);
@@ -131,9 +137,14 @@ const noteTree = (function() {
         for (const note of notes) {
             notesTreeMap[note.noteTreeId] = note;
 
-            noteIdToTitle[note.noteId] = note.title;
+            noteIdToNote[note.noteId] = {
+                title: note.title,
+                isProtected: note.isProtected,
+                type: note.type,
+                mime: note.mime
+            };
 
-            delete note.title; // this should not be used. Use noteIdToTitle instead
+            delete note.title; // this should not be used. Use noteIdToNote instead
 
             setParentChildRelation(note.noteTreeId, note.parentNoteId, note.noteId);
         }
@@ -174,7 +185,7 @@ const noteTree = (function() {
             const noteTreeId = getNoteTreeId(parentNoteId, noteId);
             const noteTree = notesTreeMap[noteTreeId];
 
-            const title = (noteTree.prefix ? (noteTree.prefix + " - ") : "") + noteIdToTitle[noteTree.noteId];
+            const title = (noteTree.prefix ? (noteTree.prefix + " - ") : "") + getNote(noteTree.noteId).title;
 
             const node = {
                 noteId: noteTree.noteId,
@@ -585,7 +596,7 @@ const noteTree = (function() {
             init: (event, data) => {
                 const noteId = treeUtils.getNoteIdFromNotePath(startNotePath);
 
-                if (noteIdToTitle[noteId] === undefined) {
+                if (noteIdToNote[noteId] === undefined) {
                     // note doesn't exist so don't try to activate it
                     startNotePath = null;
                 }
@@ -742,7 +753,7 @@ const noteTree = (function() {
     function setNoteTitle(noteId, title) {
         assertArguments(noteId);
 
-        noteIdToTitle[noteId] = title;
+        getNote(noteId).title = title;
 
         getNodesByNoteId(noteId).map(clone => treeUtils.setNodeTitleWithPrefix(clone));
     }
@@ -775,7 +786,12 @@ const noteTree = (function() {
 
         notesTreeMap[result.noteTreeId] = result;
 
-        noteIdToTitle[result.noteId] = newNoteName;
+        noteIdToNote[result.noteId] = {
+            title: result.title,
+            isProtected: result.isProtected,
+            type: result.type,
+            mime: result.mime
+        };
 
         noteEditor.newNoteCreated();