From 4d752219387e06f1f52f0e7337f8baff9a4d3e30 Mon Sep 17 00:00:00 2001
From: Elian Doran <contact@eliandoran.me>
Date: Tue, 9 Dec 2025 12:41:54 +0200
Subject: [PATCH] chore(breadcrumbs): address requested changes

---
 apps/client/src/widgets/Breadcrumb.tsx           | 16 ++++++----------
 .../src/widgets/containers/content_header.ts     |  3 +--
 2 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/apps/client/src/widgets/Breadcrumb.tsx b/apps/client/src/widgets/Breadcrumb.tsx
index 5af9caabe..c3ec93504 100644
--- a/apps/client/src/widgets/Breadcrumb.tsx
+++ b/apps/client/src/widgets/Breadcrumb.tsx
@@ -38,7 +38,7 @@ export default function Breadcrumb() {
                     {notePath.slice(-FINAL_ITEMS).map((item, index) => (
                         <Fragment key={item}>
                             <BreadcrumbSeparator notePath={notePath[notePath.length - FINAL_ITEMS - (1 - index)]} activeNotePath={item} noteContext={noteContext} />
-                            <BreadcrumbItem notePath={item} activeNotePath={noteContext?.notePath ?? ""} />
+                            <BreadcrumbItem notePath={item} />
                         </Fragment>
                     ))}
                 </>
@@ -47,7 +47,7 @@ export default function Breadcrumb() {
                     <Fragment key={item}>
                         {index === 0
                             ? <BreadcrumbRoot noteContext={noteContext} />
-                            : <BreadcrumbItem notePath={item} activeNotePath={noteContext?.notePath ?? ""} />
+                            : <BreadcrumbItem notePath={item} />
                         }
                         {(index < notePath.length - 1 || note?.hasChildren()) &&
                             <BreadcrumbSeparator notePath={item} activeNotePath={notePath[index + 1]} noteContext={noteContext} />}
@@ -76,14 +76,11 @@ function BreadcrumbRoot({ noteContext }: { noteContext: NoteContext | undefined
     );
 }
 
-function BreadcrumbItem({ notePath, activeNotePath }: { notePath: string, activeNotePath: string }) {
-    const isRootNote = (notePath === "root");
+function BreadcrumbItem({ notePath }: { notePath: string }) {
     return (
         <NoteLink
             notePath={notePath}
             noPreview
-            title={isRootNote && activeNotePath !== "root" ? "" : undefined}
-            showNoteIcon={isRootNote}
         />
     );
 }
@@ -104,14 +101,13 @@ function BreadcrumbSeparator({ notePath, noteContext, activeNotePath }: { notePa
 
 function BreadcrumbSeparatorDropdownContent({ notePath, noteContext, activeNotePath }: { notePath: string, activeNotePath: string, noteContext: NoteContext | undefined }) {
     const notePathComponents = notePath.split("/");
-    const notePathPrefix = notePathComponents.join("/");
     const parentNoteId = notePathComponents.at(-1);
     const childNotes = useChildNotes(parentNoteId);
 
     return (
-        <ul class="breadcrumb-child-list">
+        <ul className="breadcrumb-child-list">
             {childNotes.map((note) => {
-                const childNotePath = `${notePathPrefix}/${note.noteId}`;
+                const childNotePath = `${notePath}/${note.noteId}`;
                 return <li key={note.noteId}>
                     <FormListItem
                         icon={note.getIcon()}
@@ -136,7 +132,7 @@ function BreadcrumbCollapsed({ items, noteContext }: { items: string[], noteCont
             hideToggleArrow
             dropdownOptions={{ popperConfig: { strategy: "fixed" } }}
         >
-            <ul class="breadcrumb-child-list">
+            <ul className="breadcrumb-child-list">
                 {items.map((notePath) => {
                     const notePathComponents = notePath.split("/");
                     const noteId = notePathComponents[notePathComponents.length - 1];
diff --git a/apps/client/src/widgets/containers/content_header.ts b/apps/client/src/widgets/containers/content_header.ts
index 17ec4651f..32b2d13a4 100644
--- a/apps/client/src/widgets/containers/content_header.ts
+++ b/apps/client/src/widgets/containers/content_header.ts
@@ -49,9 +49,8 @@ export default class ContentHeader extends Container<BasicWidget> {
 
         if (hasMovedEnough) {
             this.setFloating(isScrollingUp);
-            this.previousScrollTop = currentScrollTop;
         }
-
+        this.previousScrollTop = currentScrollTop;
         this.updateSafeMargin();
     }