From 4b1d2c6bade2cdc63dc8bccca48cb0017dba1af0 Mon Sep 17 00:00:00 2001
From: Elian Doran <contact@eliandoran.me>
Date: Sat, 17 Feb 2024 01:24:37 +0200
Subject: [PATCH] server-ts: Port options service

---
 src/becca/becca-interface.ts            |  2 ++
 src/services/{options.js => options.ts} | 27 +++++++++++--------------
 2 files changed, 14 insertions(+), 15 deletions(-)
 rename src/services/{options.js => options.ts} (72%)

diff --git a/src/becca/becca-interface.ts b/src/becca/becca-interface.ts
index 6b36892b3..041e4b0cc 100644
--- a/src/becca/becca-interface.ts
+++ b/src/becca/becca-interface.ts
@@ -11,6 +11,8 @@ import BAttribute = require('./entities/battribute');
  * There's a similar frontend cache Froca, and share cache Shaca.
  */
 class Becca {
+    loaded!: boolean;
+
     notes!: Record<string, BNote>;
     attributes!: Record<string, BAttribute>;
     /** Points from attribute type-name to list of attributes */
diff --git a/src/services/options.js b/src/services/options.ts
similarity index 72%
rename from src/services/options.js
rename to src/services/options.ts
index e7e90331b..41532d74f 100644
--- a/src/services/options.js
+++ b/src/services/options.ts
@@ -1,22 +1,21 @@
-const becca = require('../becca/becca.js');
-const sql = require('./sql');
+import becca = require('../becca/becca');
+import { OptionRow } from '../becca/entities/rows';
+import sql = require('./sql');
 
-/** @returns {string|null} */
-function getOptionOrNull(name) {
+function getOptionOrNull(name: string): string | null {
     let option;
 
     if (becca.loaded) {
         option = becca.getOption(name);
     } else {
         // e.g. in initial sync becca is not loaded because DB is not initialized
-        option = sql.getRow("SELECT * FROM options WHERE name = ?", [name]);
+        option = sql.getRow<OptionRow>("SELECT * FROM options WHERE name = ?", [name]);
     }
 
     return option ? option.value : null;
 }
 
-/** @returns {string} */
-function getOption(name) {
+function getOption(name: string): string {
     const val = getOptionOrNull(name);
 
     if (val === null) {
@@ -26,8 +25,7 @@ function getOption(name) {
     return val;
 }
 
-/** @returns {int} */
-function getOptionInt(name, defaultValue = undefined) {
+function getOptionInt(name: string, defaultValue?: number): number {
     const val = getOption(name);
 
     const intVal = parseInt(val);
@@ -43,8 +41,7 @@ function getOptionInt(name, defaultValue = undefined) {
     return intVal;
 }
 
-/** @returns {boolean} */
-function getOptionBool(name) {
+function getOptionBool(name: string): boolean {
     const val = getOption(name);
 
     if (!['true', 'false'].includes(val)) {
@@ -54,7 +51,7 @@ function getOptionBool(name) {
     return val === 'true';
 }
 
-function setOption(name, value) {
+function setOption(name: string, value: string | boolean) {
     if (value === true || value === false) {
         value = value.toString();
     }
@@ -71,9 +68,9 @@ function setOption(name, value) {
     }
 }
 
-function createOption(name, value, isSynced) {
+function createOption(name: string, value: string, isSynced: boolean) {
     // to avoid circular dependency, need to find a better solution
-    const BOption = require('../becca/entities/boption.js');
+    const BOption = require('../becca/entities/boption');
 
     new BOption({
         name: name,
@@ -87,7 +84,7 @@ function getOptions() {
 }
 
 function getOptionMap() {
-    const map = {};
+    const map: Record<string, string> = {};
 
     for (const option of Object.values(becca.options)) {
         map[option.name] = option.value;