From 464d8417f5a1ab3cf5a4b3f7490d88b812e59fd9 Mon Sep 17 00:00:00 2001 From: Jin <22962980+JYC333@users.noreply.github.com> Date: Tue, 3 Sep 2024 17:08:07 +0200 Subject: [PATCH] fix all dropdowns and tooltips, fix some translations --- src/public/app/services/note_autocomplete.js | 27 +++++-------- .../widgets/bulk_actions/execute_script.js | 2 +- .../widgets/bulk_actions/label/add_label.js | 4 +- .../bulk_actions/label/update_label_value.js | 4 +- .../widgets/bulk_actions/note/delete_note.js | 4 +- .../bulk_actions/note/delete_revisions.js | 2 +- .../widgets/bulk_actions/note/move_note.js | 4 +- .../widgets/bulk_actions/note/rename_note.js | 2 +- .../bulk_actions/relation/add_relation.js | 4 +- .../relation/update_relation_target.js | 4 +- .../widgets/buttons/attachments_actions.js | 13 +++--- src/public/app/widgets/dialogs/add_link.js | 8 ++-- .../app/widgets/dialogs/bulk_actions.js | 11 ++--- src/public/app/widgets/dialogs/import.js | 20 +++++----- .../app/widgets/dialogs/note_type_chooser.js | 29 +++++++------- .../dialogs/protected_session_password.js | 16 +++----- .../app/widgets/dialogs/upload_attachments.js | 14 +++---- src/public/app/widgets/editability_select.js | 8 ++-- src/public/app/widgets/note_icon.js | 3 +- src/public/app/widgets/note_type.js | 13 +++--- src/public/app/widgets/quick_search.js | 38 +++++++++--------- .../ribbon_widgets/search_definition.js | 4 +- .../app/widgets/search_options/debug.js | 4 +- .../app/widgets/search_options/fast_search.js | 2 +- .../app/widgets/search_options/limit.js | 2 +- .../widgets/search_options/search_script.js | 4 +- .../widgets/search_options/search_string.js | 19 +++++---- src/public/app/widgets/sync_status.js | 40 +++++++++---------- src/public/stylesheets/style.css | 2 +- src/public/translations/cn/translation.json | 17 ++++++-- src/public/translations/en/translation.json | 11 +++++ 31 files changed, 173 insertions(+), 162 deletions(-) diff --git a/src/public/app/services/note_autocomplete.js b/src/public/app/services/note_autocomplete.js index 09548284b..dbee214b7 100644 --- a/src/public/app/services/note_autocomplete.js +++ b/src/public/app/services/note_autocomplete.js @@ -105,28 +105,23 @@ function initNoteAutocomplete($el, options) { $el.addClass("note-autocomplete-input"); - const $clearTextButton = $("") - .addClass("input-group-text input-clearer-button bx bxs-tag-x") - .prop("title", "Clear text field"); + const $clearTextButton = $(" @@ -61,7 +61,8 @@ export default class AttachmentActionsWidget extends BasicWidget { doRender() { this.$widget = $(TPL); - this.$widget.on('click', '.dropdown-item', () => this.$widget.find("[data-toggle='dropdown']").dropdown('toggle')); + this.dropdown = bootstrap.Dropdown.getOrCreateInstance(this.$widget.find("[data-bs-toggle='dropdown']")); + this.$widget.on('click', '.dropdown-item', () => this.dropdown.toggle()); this.$uploadNewRevisionInput = this.$widget.find(".attachment-upload-new-revision-input"); this.$uploadNewRevisionInput.on('change', async () => { @@ -84,7 +85,7 @@ export default class AttachmentActionsWidget extends BasicWidget { .addClass("disabled") .append($(' (?)') .attr("title", t('attachments_actions.open_externally_detail_page')) - ); + ); if (isElectron) { const $openAttachmentCustomButton = this.$widget.find("[data-trigger-command='openAttachmentCustom']"); $openAttachmentCustomButton @@ -94,7 +95,7 @@ export default class AttachmentActionsWidget extends BasicWidget { ); } } - if (!isElectron){ + if (!isElectron) { const $openAttachmentCustomButton = this.$widget.find("[data-trigger-command='openAttachmentCustom']"); $openAttachmentCustomButton .addClass("disabled") @@ -138,7 +139,7 @@ export default class AttachmentActionsWidget extends BasicWidget { return; } - const {note: newNote} = await server.post(`attachments/${this.attachmentId}/convert-to-note`) + const { note: newNote } = await server.post(`attachments/${this.attachmentId}/convert-to-note`) toastService.showMessage(t('attachments_actions.convert_success', { title: this.attachment.title })); await ws.waitForMaxKnownEntityChangeId(); await appContext.tabManager.getActiveContext().setNote(newNote.noteId); @@ -155,6 +156,6 @@ export default class AttachmentActionsWidget extends BasicWidget { return; } - await server.put(`attachments/${this.attachmentId}/rename`, {title: attachmentTitle}); + await server.put(`attachments/${this.attachmentId}/rename`, { title: attachmentTitle }); } } diff --git a/src/public/app/widgets/dialogs/add_link.js b/src/public/app/widgets/dialogs/add_link.js index 6bc768a01..e449cd4b4 100644 --- a/src/public/app/widgets/dialogs/add_link.js +++ b/src/public/app/widgets/dialogs/add_link.js @@ -9,13 +9,11 @@ const TPL = `