From 4433d034db225e2e8953024c6c4b94a8208c7440 Mon Sep 17 00:00:00 2001 From: Elian Doran Date: Sun, 1 Mar 2026 17:57:06 +0200 Subject: [PATCH] fix(ci): unblock signing not working due to bad shell & missing variable --- .github/actions/build-electron/action.yml | 4 +--- .github/workflows/nightly.yml | 1 + .github/workflows/release.yml | 1 + 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/actions/build-electron/action.yml b/.github/actions/build-electron/action.yml index 0e0264ad54..283b9c384f 100644 --- a/.github/actions/build-electron/action.yml +++ b/.github/actions/build-electron/action.yml @@ -75,9 +75,7 @@ runs: - name: Unblock signing if: ${{ inputs.os == 'windows' }} shell: ${{ inputs.shell }} - run: | - cat ${{ vars.WINDOWS_SIGN_ERROR_LOG }} - rm ${{ vars.WINDOWS_SIGN_ERROR_LOG }} + run: del ${{ env.WINDOWS_SIGN_ERROR_LOG }} - name: Update build info shell: ${{ inputs.shell }} diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 4a2ee7c946..57150e41a3 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -87,6 +87,7 @@ jobs: APPLE_ID: ${{ secrets.APPLE_ID }} APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }} WINDOWS_SIGN_EXECUTABLE: ${{ vars.WINDOWS_SIGN_EXECUTABLE }} + WINDOWS_SIGN_ERROR_LOG: ${{ vars.WINDOWS_SIGN_ERROR_LOG }} GPG_SIGNING_KEY: ${{ secrets.GPG_SIGN_KEY }} - name: Publish release diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 6d19dc2ee1..14210f03a7 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -90,6 +90,7 @@ jobs: APPLE_ID: ${{ secrets.APPLE_ID }} APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }} WINDOWS_SIGN_EXECUTABLE: ${{ vars.WINDOWS_SIGN_EXECUTABLE }} + WINDOWS_SIGN_ERROR_LOG: ${{ vars.WINDOWS_SIGN_ERROR_LOG }} GPG_SIGNING_KEY: ${{ secrets.GPG_SIGN_KEY }} - name: Upload the artifact