From 3edd8f6c5a0287ed6a3c4ad4ae5455b24ad3572f Mon Sep 17 00:00:00 2001 From: Elian Doran Date: Wed, 11 Mar 2026 20:38:53 +0200 Subject: [PATCH] chore(media): solve linter warnings --- apps/client/src/widgets/type_widgets/file/Audio.tsx | 2 +- apps/client/src/widgets/type_widgets/file/MediaPlayer.tsx | 8 ++++---- apps/client/src/widgets/type_widgets/file/Video.tsx | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/apps/client/src/widgets/type_widgets/file/Audio.tsx b/apps/client/src/widgets/type_widgets/file/Audio.tsx index 36eda0b774..9dac014074 100644 --- a/apps/client/src/widgets/type_widgets/file/Audio.tsx +++ b/apps/client/src/widgets/type_widgets/file/Audio.tsx @@ -108,5 +108,5 @@ function useKeyboardShortcuts(audioRef: MutableRef, wra audio.currentTime = audio.duration; break; } - }, [togglePlayback]); + }, [ audioRef, togglePlayback ]); } diff --git a/apps/client/src/widgets/type_widgets/file/MediaPlayer.tsx b/apps/client/src/widgets/type_widgets/file/MediaPlayer.tsx index edd689d98e..6d368d6270 100644 --- a/apps/client/src/widgets/type_widgets/file/MediaPlayer.tsx +++ b/apps/client/src/widgets/type_widgets/file/MediaPlayer.tsx @@ -25,7 +25,7 @@ export function SeekBar({ mediaRef }: { mediaRef: RefObject { const media = mediaRef.current; @@ -96,7 +96,7 @@ export function VolumeControl({ mediaRef }: { mediaRef: RefObject media.removeEventListener("volumechange", onVolumeChange); - }, []); + }, [ mediaRef ]); const onVolumeChange = (e: Event) => { const media = mediaRef.current; @@ -160,7 +160,7 @@ export function LoopButton({ mediaRef }: { mediaRef: RefObject setLoop(media.loop)); observer.observe(media, { attributes: true, attributeFilter: ["loop"] }); return () => observer.disconnect(); - }, []); + }, [ mediaRef ]); const toggle = () => { const media = mediaRef.current; @@ -193,7 +193,7 @@ export function PlaybackSpeed({ mediaRef }: { mediaRef: RefObject setSpeed(media.playbackRate); media.addEventListener("ratechange", onRateChange); return () => media.removeEventListener("ratechange", onRateChange); - }, []); + }, [ mediaRef ]); const selectSpeed = (rate: number) => { const media = mediaRef.current; diff --git a/apps/client/src/widgets/type_widgets/file/Video.tsx b/apps/client/src/widgets/type_widgets/file/Video.tsx index d8a2c42009..08fe5db4cb 100644 --- a/apps/client/src/widgets/type_widgets/file/Video.tsx +++ b/apps/client/src/widgets/type_widgets/file/Video.tsx @@ -138,7 +138,7 @@ function useKeyboardShortcuts(videoRef: MutableRef, wra flashControls(); break; } - }, [togglePlayback, flashControls]); + }, [ wrapperRef, videoRef, togglePlayback, flashControls ]); } function useAutoHideControls(videoRef: RefObject, playing: boolean) { @@ -150,7 +150,7 @@ function useAutoHideControls(videoRef: RefObject, playing: boo if (videoRef.current && !videoRef.current.paused) { hideTimerRef.current = setTimeout(() => setVisible(false), AUTO_HIDE_DELAY); } - }, []); + }, [ videoRef]); const onMouseMove = useCallback(() => { setVisible(true); @@ -244,7 +244,7 @@ function PictureInPictureButton({ videoRef }: { videoRef: RefObject