gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-06-06 18:08:33 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

lazy loading of note detail components

Browse Source
This commit is contained in:
zadam 2019-08-26 19:49:19 +02:00
parent ecb485c8bc
commit 3e3d111d76
2 changed files with 31 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/public/javascripts/services/note_detail.js
View File

@ -191,7 +191,7 @@ async function renderComponent(ctx) {
* @param {NoteFull} note * @param {NoteFull} note
*/ */
async function loadNoteDetailToContext(ctx, note, notePath) { async function loadNoteDetailToContext(ctx, note, notePath) {
ctx.setNote(note, notePath); await ctx.setNote(note, notePath);
openTabsChanged(); openTabsChanged();

57
src/public/javascripts/services/tab_context.js
View File

@ -7,15 +7,6 @@ import treeUtils from "./tree_utils.js";
import utils from "./utils.js"; import utils from "./utils.js";
import NoteTypeContext from "./note_type.js"; import NoteTypeContext from "./note_type.js";
import noteDetailService from "./note_detail.js"; import noteDetailService from "./note_detail.js";
import noteDetailEmpty from "./note_detail_empty.js";
import noteDetailText from "./note_detail_text.js";
import noteDetailCode from "./note_detail_code.js";
import noteDetailFile from "./note_detail_file.js";
import noteDetailImage from "./note_detail_image.js";
import noteDetailSearch from "./note_detail_search.js";
import noteDetailRender from "./note_detail_render.js";
import noteDetailRelationMap from "./note_detail_relation_map.js";
import noteDetailProtectedSession from "./note_detail_protected_session.js";
import protectedSessionService from "./protected_session.js"; import protectedSessionService from "./protected_session.js";
import optionsService from "./options.js"; import optionsService from "./options.js";
import linkService from "./link.js"; import linkService from "./link.js";
@ -24,15 +15,15 @@ import Sidebar from "./sidebar.js";
const $tabContentsContainer = $("#note-tab-container"); const $tabContentsContainer = $("#note-tab-container");
const componentClasses = { const componentClasses = {
'empty': noteDetailEmpty, 'empty': "./note_detail_empty.js",
'text': noteDetailText, 'text': "./note_detail_text.js",
'code': noteDetailCode, 'code': "./note_detail_code.js",
'file': noteDetailFile, 'file': "./note_detail_file.js",
'image': noteDetailImage, 'image': "./note_detail_image.js",
'search': noteDetailSearch, 'search': "./note_detail_search.js",
'render': noteDetailRender, 'render': "./note_detail_render.js",
'relation-map': noteDetailRelationMap, 'relation-map': "./note_detail_relation_map.js",
'protected-session': noteDetailProtectedSession 'protected-session': "./note_detail_protected_session.js"
}; };
let showSidebarInNewTab = true; let showSidebarInNewTab = true;
@ -114,7 +105,7 @@ class TabContext {
console.debug(`Created note tab ${this.tabId}`); console.debug(`Created note tab ${this.tabId}`);
} }
setNote(note, notePath) { async setNote(note, notePath) {
this.noteId = note.noteId; this.noteId = note.noteId;
this.notePath = notePath; this.notePath = notePath;
/** @property {NoteFull} */ /** @property {NoteFull} */
@ -123,6 +114,8 @@ class TabContext {
this.attributes.invalidateAttributes(); this.attributes.invalidateAttributes();
await this.initComponent();
this.setupClasses(); this.setupClasses();
this.setCurrentNotePathToHash(); this.setCurrentNotePathToHash();
@ -209,7 +202,23 @@ class TabContext {
this.$unprotectButton.prop("disabled", !this.note.isProtected || !protectedSessionHolder.isProtectedSessionAvailable()); this.$unprotectButton.prop("disabled", !this.note.isProtected || !protectedSessionHolder.isProtectedSessionAvailable());
} }
async initComponent() {
const type = this.getComponentType();
if (!(type in this.components)) {
const clazz = await import(componentClasses[type]);
this.components[type] = new clazz.default(this);
}
}
getComponent() { getComponent() {
const type = this.getComponentType();
return this.components[type];
}
getComponentType() {
let type; let type;
if (this.note) { if (this.note) {
@ -225,16 +234,10 @@ class TabContext {
this.$noteTitle.prop("readonly", true); this.$noteTitle.prop("readonly", true);
} }
} }
} } else {
else {
type = 'empty'; type = 'empty';
} }
return type;
if (!(type in this.components)) {
this.components[type] = new componentClasses[type](this);
}
return this.components[type];
} }
async activate() { async activate() {