gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2026-01-10 16:44:29 +01:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

chore(window): simplify replacement logic for open windows
Some checks are pending
Checks / main (push) Waiting to run
Details

Browse Source
This commit is contained in:
SiriusXT 2026-01-04 18:49:08 +08:00
parent 9e8d89a170
commit 3a9e686533
1 changed files with 10 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
apps/client/src/components/tab_manager.ts
View File

@ -149,31 +149,18 @@ export default class TabManager extends Component {
currentWin.contexts = filteredNoteContexts;
} else {
if (savedWindows?.length >= MAX_SAVED_WINDOWS) {
// Filter out the oldest entry
// Filter out a window to remove
// 1) Never remove the "main" window
// 2) Prefer removing the oldest closed window (closedAt !== 0)
// 3) If no closed window exists, remove the window with the oldest created window
let oldestClosedIndex = -1;
let oldestClosedTime = Infinity;
let oldestCreatedIndex = -1;
let oldestCreatedTime = Infinity;
savedWindows.forEach((w: WindowState, i: number) => {
if (w.windowId === "main") return;
if (w.closedAt !== 0) {
if (w.closedAt < oldestClosedTime) {
oldestClosedTime = w.closedAt;
oldestClosedIndex = i;
}
} else {
if (w.createdAt < oldestCreatedTime) {
oldestCreatedTime = w.createdAt;
oldestCreatedIndex = i;
}
// 2) Remove the window with the oldest creation time
let windowToRemove: WindowState | null = null;
for (const win of savedWindows) {
if (win.windowId === "main") continue; // never remove main
if (!windowToRemove || win.createdAt < windowToRemove.createdAt) {
windowToRemove = win;
}
});
const indexToRemove = oldestClosedIndex !== -1 ? oldestClosedIndex : oldestCreatedIndex;
if (indexToRemove !== -1) {
savedWindows.splice(indexToRemove, 1);
}
if (windowToRemove) {
savedWindows.splice(savedWindows.indexOf(windowToRemove), 1);
}
}