From 35fab7a23c39e385968068f71002accec95b067d Mon Sep 17 00:00:00 2001 From: zadam Date: Fri, 26 Aug 2022 22:02:40 +0200 Subject: [PATCH] fixes overwriting attributes after clicking on a relation in the attribute editor, closes #3090 --- .../app/widgets/attribute_widgets/attribute_editor.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/public/app/widgets/attribute_widgets/attribute_editor.js b/src/public/app/widgets/attribute_widgets/attribute_editor.js index bbc27fe4f..84fba78b1 100644 --- a/src/public/app/widgets/attribute_widgets/attribute_editor.js +++ b/src/public/app/widgets/attribute_widgets/attribute_editor.js @@ -297,6 +297,12 @@ export default class AttributeEditorWidget extends NoteContextAwareWidget { } async save() { + if (this.lastUpdatedNoteId !== this.noteId) { + // https://github.com/zadam/trilium/issues/3090 + console.warn("Ignoring blur event because a different note is loaded."); + return; + } + const attributes = this.parseAttributes(); if (attributes) { @@ -354,6 +360,8 @@ export default class AttributeEditorWidget extends NoteContextAwareWidget { } dataChanged() { + this.lastUpdatedNoteId = this.noteId; + if (this.lastSavedContent === this.textEditor.getData()) { this.$saveAttributesButton.fadeOut(); }