gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-11-01 03:59:05 +01:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

chore(react/collections): avoid intersection observer when not needed

Browse Source
This commit is contained in:
Elian Doran 2025-08-30 19:48:05 +03:00
parent 6e575df40b
commit 34fc30b8db
No known key found for this signature in database
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
apps/client/src/widgets/collections/NoteList.tsx
View File

@ -11,18 +11,23 @@ interface NoteListProps {
highlightedTokens?: string[] | null; highlightedTokens?: string[] | null;
} }
export default function NoteList({ note: providedNote, highlightedTokens }: NoteListProps) { export default function NoteList({ note: providedNote, highlightedTokens, displayOnlyCollections }: NoteListProps) {
const widgetRef = useRef<HTMLDivElement>(null); const widgetRef = useRef<HTMLDivElement>(null);
const { note: contextNote } = useNoteContext(); const { note: contextNote, noteContext } = useNoteContext();
const note = providedNote ?? contextNote; const note = providedNote ?? contextNote;
const viewType = useNoteViewType(note); const viewType = useNoteViewType(note);
const noteIds = useNoteIds(note, viewType); const noteIds = useNoteIds(note, viewType);
const isFullHeight = (viewType !== "list" && viewType !== "grid"); const isFullHeight = (viewType !== "list" && viewType !== "grid");
const [ isIntersecting, setIsIntersecting ] = useState(false); const [ isIntersecting, setIsIntersecting ] = useState(false);
const shouldRender = (isFullHeight || isIntersecting); const shouldRender = (isFullHeight || isIntersecting);
const isEnabled = (note && !!viewType && shouldRender); const isEnabled = (note && noteContext?.hasNoteList() && !!viewType && shouldRender);
useEffect(() => { useEffect(() => {
if (isFullHeight || displayOnlyCollections) {
// Double role: no need to check if the note list is visible if the view is full-height, but also prevent legacy views if `displayOnlyCollections` is true.
return;
}
const observer = new IntersectionObserver( const observer = new IntersectionObserver(
(entries) => { (entries) => {
if (!isIntersecting) { if (!isIntersecting) {