From 31990a999293a9bfa2dc0fa396fe8c94ead4e859 Mon Sep 17 00:00:00 2001
From: Papierkorb2292 <104673791+Papierkorb2292@users.noreply.github.com>
Date: Sun, 28 Sep 2025 17:41:25 +0200
Subject: [PATCH] Let browser display webview with max size instead of manually
adjusting the size, so the webview size is sure to be updated when a parent
element changes size
---
.../src/widgets/type_widgets/web_view.ts | 20 ++++++-------------
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/apps/client/src/widgets/type_widgets/web_view.ts b/apps/client/src/widgets/type_widgets/web_view.ts
index 26575d3dc..1c2fee53d 100644
--- a/apps/client/src/widgets/type_widgets/web_view.ts
+++ b/apps/client/src/widgets/type_widgets/web_view.ts
@@ -7,6 +7,12 @@ import utils from "../../services/utils.js";
const TPL = /*html*/`
+
${t("web_view.web_view")}
@@ -40,8 +46,6 @@ export default class WebViewTypeWidget extends TypeWidget {
this.$noteDetailWebViewHelp = this.$widget.find(".note-detail-web-view-help");
this.$noteDetailWebViewContent = this.$widget.find(".note-detail-web-view-content");
- window.addEventListener("resize", () => this.setDimensions(), false);
-
super.doRender();
}
@@ -62,24 +66,12 @@ export default class WebViewTypeWidget extends TypeWidget {
this.$noteDetailWebViewContent.hide();
this.$noteDetailWebViewHelp.show();
}
-
- this.setDimensions();
-
- setTimeout(() => this.setDimensions(), 1000);
}
cleanup() {
this.$noteDetailWebViewContent.removeAttr("src");
}
- setDimensions() {
- const $parent = this.$widget;
-
- this.$noteDetailWebViewContent
- .height($parent.height() ?? 0)
- .width($parent.width() ?? 0);
- }
-
entitiesReloadedEvent({ loadResults }: EventData<"entitiesReloaded">) {
if (loadResults.getAttributeRows().find((attr) => attr.name === "webViewSrc" && attributeService.isAffecting(attr, this.noteContext?.note))) {
this.refresh();