From 2ad4b26c9ee552ffee75fd1fe9710cfa416bb319 Mon Sep 17 00:00:00 2001
From: Elian Doran <contact@eliandoran.me>
Date: Wed, 6 Aug 2025 18:01:26 +0300
Subject: [PATCH] chore(react/dialogs): reintroduce footer in note revisions

---
 apps/client/src/widgets/dialogs/revisions.tsx | 33 ++++++++++++++++++-
 .../client/src/widgets/react/ActionButton.tsx | 13 ++++++++
 apps/client/src/widgets/react/Modal.tsx       | 11 ++++---
 3 files changed, 51 insertions(+), 6 deletions(-)
 create mode 100644 apps/client/src/widgets/react/ActionButton.tsx

diff --git a/apps/client/src/widgets/dialogs/revisions.tsx b/apps/client/src/widgets/dialogs/revisions.tsx
index cc7438cf2..d66a04fda 100644
--- a/apps/client/src/widgets/dialogs/revisions.tsx
+++ b/apps/client/src/widgets/dialogs/revisions.tsx
@@ -16,6 +16,8 @@ import protected_session_holder from "../../services/protected_session_holder";
 import { renderMathInElement } from "../../services/math";
 import { CSSProperties } from "preact/compat";
 import open from "../../services/open";
+import ActionButton from "../react/ActionButton";
+import options from "../../services/options";
 
 interface RevisionsDialogProps {
     note?: FNote;
@@ -54,7 +56,9 @@ function RevisionsDialogComponent({ note }: RevisionsDialogProps) {
                             toast.showMessage(t("revisions.revisions_deleted"));
                         }
                     }}/>)
-            }                
+            }
+            footer={<RevisionFooter note={note} />} 
+            footerStyle={{ paddingTop: 0, paddingBottom: 0 }}
             >
                 <RevisionsList
                     revisions={revisions}
@@ -231,6 +235,33 @@ function RevisionContent({ revisionItem, fullRevision }: { revisionItem?: Revisi
     }
 }
 
+function RevisionFooter({ note }: { note: FNote }) {
+    if (!note) {
+        return <></>;
+    }
+
+    let revisionsNumberLimit: number | string = parseInt(note?.getLabelValue("versioningLimit") ?? "");
+    if (!Number.isInteger(revisionsNumberLimit)) {
+        revisionsNumberLimit = options.getInt("revisionSnapshotNumberLimit") ?? 0;
+    }
+    if (revisionsNumberLimit === -1) {
+        revisionsNumberLimit = "∞";
+    }
+    
+    return <>
+        <span class="revisions-snapshot-interval flex-grow-1 my-0 py-0">
+            {t("revisions.snapshot_interval", { seconds: options.getInt("revisionSnapshotTimeInterval") })}
+        </span>
+        <span class="maximum-revisions-for-current-note flex-grow-1 my-0 py-0">
+            {t("revisions.maximum_revisions", { number: revisionsNumberLimit })}
+        </span>
+        <ActionButton
+            icon="bx bx-cog" text={t("revisions.settings")}
+            onClick={() => appContext.tabManager.openContextWithNote("_optionsOther", { activate: true })}
+        />
+    </>;
+}
+
 export default class RevisionsDialog extends ReactBasicWidget  {
 
     private props: RevisionsDialogProps = {};
diff --git a/apps/client/src/widgets/react/ActionButton.tsx b/apps/client/src/widgets/react/ActionButton.tsx
new file mode 100644
index 000000000..5adacc5c1
--- /dev/null
+++ b/apps/client/src/widgets/react/ActionButton.tsx
@@ -0,0 +1,13 @@
+interface ActionButtonProps {
+    text: string;
+    icon: string;
+    onClick?: () => void;
+}
+
+export default function ActionButton({ text, icon, onClick }: ActionButtonProps) {
+    return <button
+        class={`icon-action ${icon}`}
+        title={text}
+        onClick={onClick}
+    />;
+}
\ No newline at end of file
diff --git a/apps/client/src/widgets/react/Modal.tsx b/apps/client/src/widgets/react/Modal.tsx
index 24f0a356e..1f020b56b 100644
--- a/apps/client/src/widgets/react/Modal.tsx
+++ b/apps/client/src/widgets/react/Modal.tsx
@@ -13,6 +13,7 @@ interface ModalProps {
      */
     header?: ComponentChildren;
     footer?: ComponentChildren;
+    footerStyle?: CSSProperties;
     footerAlignment?: "right" | "between";
     minWidth?: string;
     maxWidth?: number;
@@ -46,7 +47,7 @@ interface ModalProps {
     bodyStyle?: CSSProperties;
 }
 
-export default function Modal({ children, className, size, title, header, footer, footerAlignment, onShown, onSubmit, helpPageId, minWidth, maxWidth, zIndex, scrollable, onHidden: onHidden, modalRef: _modalRef, formRef: _formRef, bodyStyle }: ModalProps) {
+export default function Modal({ children, className, size, title, header, footer, footerStyle, footerAlignment, onShown, onSubmit, helpPageId, minWidth, maxWidth, zIndex, scrollable, onHidden: onHidden, modalRef: _modalRef, formRef: _formRef, bodyStyle }: ModalProps) {
     const modalRef = _modalRef ?? useRef<HTMLDivElement>(null);
     const formRef = _formRef ?? useRef<HTMLFormElement>(null);
 
@@ -108,10 +109,10 @@ export default function Modal({ children, className, size, title, header, footer
                             e.preventDefault();
                             onSubmit();
                         }}>
-                            <ModalInner footer={footer} bodyStyle={bodyStyle}>{children}</ModalInner>
+                            <ModalInner footer={footer} bodyStyle={bodyStyle} footerStyle={footerStyle} footerAlignment={footerAlignment}>{children}</ModalInner>
                         </form>
                     ) : (
-                        <ModalInner footer={footer} bodyStyle={bodyStyle}>
+                        <ModalInner footer={footer} bodyStyle={bodyStyle} footerStyle={footerStyle} footerAlignment={footerAlignment}>
                             {children}
                         </ModalInner>
                     )}
@@ -121,8 +122,8 @@ export default function Modal({ children, className, size, title, header, footer
     );
 }
 
-function ModalInner({ children, footer, footerAlignment, bodyStyle }: Pick<ModalProps, "children" | "footer" | "footerAlignment" | "bodyStyle">) {
-    const footerStyle: CSSProperties = {};
+function ModalInner({ children, footer, footerAlignment, bodyStyle, footerStyle: _footerStyle }: Pick<ModalProps, "children" | "footer" | "footerAlignment" | "bodyStyle" | "footerStyle">) {
+    const footerStyle: CSSProperties = _footerStyle ?? {};
     if (footerAlignment === "between") {
         footerStyle.justifyContent = "space-between";
     }