gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-10-21 07:38:53 +02:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

fix(server): saving revision of note with empty title not supported (closes #6103)

Browse Source
This commit is contained in:
Elian Doran 2025-06-27 14:22:08 +03:00
parent 45a3fb15e6
commit 256ffe39f2
No known key found for this signature in database
2 changed files with 25 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
apps/server/src/becca/entities/brevision.spec.ts Normal file
View File

@ -0,0 +1,22 @@
import BRevision from "./brevision.js";
describe("Revision", () => {
it("handles note with empty title properly", () => {
const revision = new BRevision({
revisionId: "4omM5OvlLhOw",
noteId: "WHMg7iFCRG3Z",
type: "text",
mime: "text/html",
isProtected: false,
title: "",
blobId: "",
dateLastEdited: "2025-06-27 14:10:39.688+0300",
dateCreated: "2025-06-27 14:10:39.688+0300",
utcDateLastEdited: "2025-06-27 14:10:39.688+0300",
utcDateCreated: "2025-06-27 14:10:39.688+0300",
utcDateModified: "2025-06-27 14:10:39.688+0300"
});
const pojo = revision.getPojo();
expect(pojo.title).toBeDefined();
});
});

6
apps/server/src/becca/entities/brevision.ts
View File

@ -192,7 +192,7 @@ class BRevision extends AbstractBeccaEntity<BRevision> {
type: this.type, type: this.type,
mime: this.mime, mime: this.mime,
isProtected: this.isProtected, isProtected: this.isProtected,
title: this.title || undefined, title: this.title,
blobId: this.blobId, blobId: this.blobId,
dateLastEdited: this.dateLastEdited, dateLastEdited: this.dateLastEdited,
dateCreated: this.dateCreated, dateCreated: this.dateCreated,
@ -211,10 +211,10 @@ class BRevision extends AbstractBeccaEntity<BRevision> {
if (pojo.isProtected) { if (pojo.isProtected) {
if (protectedSessionService.isProtectedSessionAvailable()) { if (protectedSessionService.isProtectedSessionAvailable()) {
pojo.title = protectedSessionService.encrypt(this.title) || undefined; pojo.title = protectedSessionService.encrypt(this.title) ?? "";
} else { } else {
// updating protected note outside of protected session means we will keep original ciphertexts // updating protected note outside of protected session means we will keep original ciphertexts
delete pojo.title; pojo.title = "";
} }
} }