diff --git a/apps/server/src/services/backend_script_api.ts b/apps/server/src/services/backend_script_api.ts index 249d09ea0..60af0fb97 100644 --- a/apps/server/src/services/backend_script_api.ts +++ b/apps/server/src/services/backend_script_api.ts @@ -412,6 +412,17 @@ export interface Api { */ backupNow(backupName: string): Promise; + /** + * Enables the complete duplication of the specified original note and all its children into the specified parent note. + * The new note will be named the same as the original, with (Dup) added to the end of it. + * + * @param origNoteId - the noteId for the original note to be duplicated + * @param newParentNoteId - the noteId for the parent note where the duplication is to be placed. + * + * @returns the note and the branch of the newly created note. + */ + duplicateSubtree(origNoteId: string, newParentNoteId: string): { note: BNote; branch: BBranch; } + /** * This object contains "at your risk" and "no BC guarantees" objects for advanced use cases. */ @@ -703,6 +714,7 @@ function BackendScriptApi(this: Api, currentNote: BNote, apiParams: ApiParams) { this.runOutsideOfSync = syncMutex.doExclusively; this.backupNow = backupService.backupNow; + this.duplicateSubtree = noteService.duplicateSubtree; this.__private = { becca diff --git a/apps/server/src/services/notes.ts b/apps/server/src/services/notes.ts index 998da821b..e225cdb52 100644 --- a/apps/server/src/services/notes.ts +++ b/apps/server/src/services/notes.ts @@ -931,10 +931,6 @@ function duplicateSubtree(origNoteId: string, newParentNoteId: string) { const noteIdMapping = getNoteIdMapping(origNote); - if (!origBranch) { - throw new Error("Unable to find original branch to duplicate."); - } - const res = duplicateSubtreeInner(origNote, origBranch, newParentNoteId, noteIdMapping); const duplicateNoteSuffix = t("notes.duplicate-note-suffix"); @@ -966,7 +962,7 @@ function duplicateSubtreeWithoutRoot(origNoteId: string, newNoteId: string) { } } -function duplicateSubtreeInner(origNote: BNote, origBranch: BBranch, newParentNoteId: string, noteIdMapping: Record) { +function duplicateSubtreeInner(origNote: BNote, origBranch: BBranch | null | undefined, newParentNoteId: string, noteIdMapping: Record) { if (origNote.isProtected && !protectedSessionService.isProtectedSessionAvailable()) { throw new Error(`Cannot duplicate note '${origNote.noteId}' because it is protected and protected session is not available. Enter protected session and try again.`); }