From b063b4c528adb93aef8f33a124676db7bc25850c Mon Sep 17 00:00:00 2001
From: zadam <adam.zivner@gmail.com>
Date: Tue, 12 May 2020 12:28:59 +0200
Subject: [PATCH 1/3] read only view images should not overflow

---
 src/public/app/widgets/type_widgets/read_only_text.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/public/app/widgets/type_widgets/read_only_text.js b/src/public/app/widgets/type_widgets/read_only_text.js
index 83ae447ac..9e7641414 100644
--- a/src/public/app/widgets/type_widgets/read_only_text.js
+++ b/src/public/app/widgets/type_widgets/read_only_text.js
@@ -22,6 +22,10 @@ const TPL = `
     .note-detail-readonly-text p:first-child, .note-detail-text::before {
         margin-top: 0;
     }
+    
+    .note-detail-readonly-text img {
+        max-width: 100%;
+    }
     </style>
 
     <div class="alert alert-warning no-print">
@@ -77,4 +81,4 @@ export default class ReadOnlyTextTypeWidget extends AbstractTextTypeWidget {
             this.loadIncludedNote(noteId, $(el));
         });
     }
-}
\ No newline at end of file
+}

From 30b9ef860491e86168beab291070cca80ab1cadc Mon Sep 17 00:00:00 2001
From: zadam <adam.zivner@gmail.com>
Date: Tue, 12 May 2020 12:45:32 +0200
Subject: [PATCH 2/3] fix tab title of deleted note

---
 src/public/app/layouts/desktop_main_window_layout.js |  4 ++--
 src/public/app/widgets/basic_widget.js               |  7 ++++++-
 src/public/app/widgets/tab_row.js                    | 12 ++++++++----
 3 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/src/public/app/layouts/desktop_main_window_layout.js b/src/public/app/layouts/desktop_main_window_layout.js
index bf0e78b37..c49376e6a 100644
--- a/src/public/app/layouts/desktop_main_window_layout.js
+++ b/src/public/app/layouts/desktop_main_window_layout.js
@@ -24,7 +24,6 @@ import NoteRevisionsWidget from "../widgets/collapsible_widgets/note_revisions.j
 import SimilarNotesWidget from "../widgets/collapsible_widgets/similar_notes.js";
 import WhatLinksHereWidget from "../widgets/collapsible_widgets/what_links_here.js";
 import SidePaneToggles from "../widgets/side_pane_toggles.js";
-import appContext from "../services/app_context.js";
 
 const RIGHT_PANE_CSS = `
 <style>
@@ -117,6 +116,7 @@ export default class DesktopMainWindowLayout {
                 .hideInZenMode())
             .child(new FlexContainer('row')
                 .collapsible()
+                .filling()
                 .child(new SidePaneContainer('left')
                     .hideInZenMode()
                     .child(new GlobalButtonsWidget())
@@ -153,4 +153,4 @@ export default class DesktopMainWindowLayout {
                 .child(new SidePaneToggles().hideInZenMode())
             );
     }
-}
\ No newline at end of file
+}
diff --git a/src/public/app/widgets/basic_widget.js b/src/public/app/widgets/basic_widget.js
index 06514edaa..b5d81142b 100644
--- a/src/public/app/widgets/basic_widget.js
+++ b/src/public/app/widgets/basic_widget.js
@@ -30,6 +30,11 @@ class BasicWidget extends Component {
         return this;
     }
 
+    filling() {
+        this.css('flex-grow', '1');
+        return this;
+    }
+
     hideInZenMode() {
         this.class('hide-in-zen-mode');
         return this;
@@ -109,4 +114,4 @@ class BasicWidget extends Component {
     cleanup() {}
 }
 
-export default BasicWidget;
\ No newline at end of file
+export default BasicWidget;
diff --git a/src/public/app/widgets/tab_row.js b/src/public/app/widgets/tab_row.js
index 0a4b39791..0ae79bcc5 100644
--- a/src/public/app/widgets/tab_row.js
+++ b/src/public/app/widgets/tab_row.js
@@ -602,18 +602,22 @@ export default class TabRowWidget extends BasicWidget {
     }
 
     updateTab($tab, note) {
-        if (!note || !$tab.length) {
+        if (!$tab.length) {
             return;
         }
 
-        this.updateTitle($tab, note.title);
-
         for (const clazz of Array.from($tab[0].classList)) { // create copy to safely iterate over while removing classes
             if (clazz !== 'note-tab') {
                 $tab.removeClass(clazz);
             }
         }
 
+        if (!note) {
+            this.updateTitle($tab, 'New tab');
+        }
+
+        this.updateTitle($tab, note.title);
+
         $tab.addClass(note.getCssClass());
         $tab.addClass(utils.getNoteTypeClass(note.type));
         $tab.addClass(utils.getMimeTypeClass(note.mime));
@@ -636,4 +640,4 @@ export default class TabRowWidget extends BasicWidget {
             this.updateTab($tab, tabContext.note);
         }
     }
-}
\ No newline at end of file
+}

From 4f50864ec8346a12d7845cb4c91a3de3b1043d34 Mon Sep 17 00:00:00 2001
From: zadam <adam.zivner@gmail.com>
Date: Tue, 12 May 2020 13:40:42 +0200
Subject: [PATCH 3/3] better UX when deleting notes - focus in note tree is
 moved to the next/previous note

---
 src/public/app/services/ws.js       | 13 +++++++++++--
 src/public/app/widgets/note_tree.js | 13 +++++++++++++
 src/public/app/widgets/tab_row.js   |  1 +
 src/services/sql.js                 |  3 ++-
 4 files changed, 27 insertions(+), 3 deletions(-)

diff --git a/src/public/app/services/ws.js b/src/public/app/services/ws.js
index 89fcdebcc..6c4e6e160 100644
--- a/src/public/app/services/ws.js
+++ b/src/public/app/services/ws.js
@@ -37,6 +37,10 @@ function subscribeToMessages(messageHandler) {
 // used to serialize sync operations
 let consumeQueuePromise = null;
 
+// most sync events are sent twice - once immediatelly after finishing the transaction and once during the scheduled ping
+// but we want to process only once
+const receivedSyncIds = new Set();
+
 async function handleMessage(event) {
     const message = JSON.parse(event.data);
 
@@ -52,14 +56,19 @@ async function handleMessage(event) {
 
         if (syncRows.length > 0) {
             const filteredRows = syncRows.filter(row =>
-                row.entityName !== 'recent_notes'
+                !receivedSyncIds.has(row.id)
+                && row.entityName !== 'recent_notes'
                 && (row.entityName !== 'options' || row.entityId !== 'openTabs'));
 
             if (filteredRows.length > 0) {
                 console.debug(utils.now(), "Sync data: ", filteredRows);
             }
 
-            syncDataQueue.push(...syncRows);
+            for (const row of filteredRows) {
+                receivedSyncIds.add(row.id);
+            }
+
+            syncDataQueue.push(...filteredRows);
 
             // we set lastAcceptedSyncId even before sync processing and send ping so that backend can start sending more updates
             lastAcceptedSyncId = Math.max(lastAcceptedSyncId, syncRows[syncRows.length - 1].id);
diff --git a/src/public/app/widgets/note_tree.js b/src/public/app/widgets/note_tree.js
index 69cb8a93c..e7c8a6c52 100644
--- a/src/public/app/widgets/note_tree.js
+++ b/src/public/app/widgets/note_tree.js
@@ -804,7 +804,9 @@ export default class NoteTreeWidget extends TabAwareWidget {
 
     async entitiesReloadedEvent({loadResults}) {
         const activeNode = this.getActiveNode();
+        const nextNode = activeNode ? (activeNode.getNextSibling() || activeNode.getPrevSibling() || activeNode.getParent()) : null;
         const activeNotePath = activeNode ? treeService.getNotePath(activeNode) : null;
+        const nextNotePath = nextNode ? treeService.getNotePath(nextNode) : null;
         const activeNoteId = activeNode ? activeNode.data.noteId : null;
 
         const noteIdsToUpdate = new Set();
@@ -926,6 +928,17 @@ export default class NoteTreeWidget extends TabAwareWidget {
             if (node) {
                 node.setActive(true, {noEvents: true});
             }
+            else {
+                // this is used when original note has been deleted and we want to move the focus to the note above/below
+                node = await this.expandToNote(nextNotePath);
+
+                if (node) {
+                    this.tree.setFocus();
+                    node.setFocus(true);
+
+                    await appContext.tabManager.getActiveTabContext().setNote(nextNotePath);
+                }
+            }
         }
     }
 
diff --git a/src/public/app/widgets/tab_row.js b/src/public/app/widgets/tab_row.js
index 0ae79bcc5..ba8ee27fc 100644
--- a/src/public/app/widgets/tab_row.js
+++ b/src/public/app/widgets/tab_row.js
@@ -614,6 +614,7 @@ export default class TabRowWidget extends BasicWidget {
 
         if (!note) {
             this.updateTitle($tab, 'New tab');
+            return;
         }
 
         this.updateTitle($tab, note.title);
diff --git a/src/services/sql.js b/src/services/sql.js
index 325dbc292..179b35103 100644
--- a/src/services/sql.js
+++ b/src/services/sql.js
@@ -221,6 +221,7 @@ async function transactional(func) {
 
             await commit();
 
+            // note that sync rows sent from this action will be sent again by scheduled periodic ping
             require('./ws.js').sendPingToAllClients();
 
             transactionActive = false;
@@ -267,4 +268,4 @@ module.exports = {
     executeScript,
     transactional,
     upsert
-};
\ No newline at end of file
+};