gaschz/trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2026-02-24 14:44:28 +01:00
Code Issues Actions 15 Packages Projects Releases Wiki Activity

fix(tree): performance issue due to batch update
Some checks failed
Checks / main (push) Has been cancelled
Details

Browse Source
This commit is contained in:
Elian Doran 2026-01-10 17:24:34 +02:00
parent ddba0e823c
commit 0272189b22
No known key found for this signature in database
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
apps/client/src/widgets/note_tree.ts
View File

@ -1306,7 +1306,7 @@ export default class NoteTreeWidget extends NoteContextAwareWidget {
}
async #executeTreeUpdates(refreshCtx: RefreshContext, loadResults: LoadResults) {
await this.batchUpdate(async () => {
const batchUpdate = async () => {
for (const noteId of refreshCtx.noteIdsToReload) {
for (const node of this.getNodesByNoteId(noteId)) {
await node.load(true);
@ -1322,7 +1322,14 @@ export default class NoteTreeWidget extends NoteContextAwareWidget {
}
}
}
});
};
if (refreshCtx.noteIdsToReload.size + refreshCtx.noteIdsToUpdate.size >= 10) {
// Despite the name, batchUpdate is actually slowing things down for smaller updates.
await this.batchUpdate(batchUpdate);
} else {
await batchUpdate();
}
// for some reason, node update cannot be in the batchUpdate() block (node is not re-rendered)
for (const noteId of refreshCtx.noteIdsToUpdate) {